From patchwork Thu Jun 29 20:39:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruno Victal X-Patchwork-Id: 1003 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id E1D7B27BBE9; Thu, 29 Jun 2023 21:41:15 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id EC4F227BBE2 for ; Thu, 29 Jun 2023 21:41:12 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qEyRr-0005Q5-Fc; Thu, 29 Jun 2023 16:41:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEyRq-0005Pv-8P for guix-patches@gnu.org; Thu, 29 Jun 2023 16:41:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qEyRq-0004y2-06 for guix-patches@gnu.org; Thu, 29 Jun 2023 16:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qEyRp-00069L-Ro; Thu, 29 Jun 2023 16:41:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64356] [PATCH 0/4] Fix GDM and VNC tests Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: maxim.cournoyer@gmail.com, guix-patches@gnu.org Resent-Date: Thu, 29 Jun 2023 20:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64356 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 64356@debbugs.gnu.org Cc: Bruno Victal , maxim.cournoyer@gmail.com X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: maxim.cournoyer@gmail.com Received: via spool by submit@debbugs.gnu.org id=B.168807120223546 (code B ref -1); Thu, 29 Jun 2023 20:41:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 Jun 2023 20:40:02 +0000 Received: from localhost ([127.0.0.1]:54122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEyQs-00067i-7g for submit@debbugs.gnu.org; Thu, 29 Jun 2023 16:40:02 -0400 Received: from lists.gnu.org ([209.51.188.17]:56264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEyQq-00067D-5F for submit@debbugs.gnu.org; Thu, 29 Jun 2023 16:40:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEyQo-00056f-A9 for guix-patches@gnu.org; Thu, 29 Jun 2023 16:39:58 -0400 Received: from smtpmciv3.myservices.hosting ([185.26.107.239]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEyQm-0004LI-L3 for guix-patches@gnu.org; Thu, 29 Jun 2023 16:39:58 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpmciv3.myservices.hosting (Postfix) with ESMTP id 282632054E for ; Thu, 29 Jun 2023 22:39:53 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 7373480097; Thu, 29 Jun 2023 22:39:53 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Ag4Nz5xkfqGf; Thu, 29 Jun 2023 22:39:53 +0200 (CEST) Received: from guix-nuc.home.arpa (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id E980A80060; Thu, 29 Jun 2023 22:39:52 +0200 (CEST) From: Bruno Victal Date: Thu, 29 Jun 2023 21:39:08 +0100 Message-Id: X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Received-SPF: pass client-ip=185.26.107.239; envelope-from=mirai@makinata.eu; helo=smtpmciv3.myservices.hosting X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches It turns out that the issue with the xvnc test was due to using invoke instead of system*. Along the way, the GDM test was refactored to replace the ugly sleep delay with a more adequate awaiting method. Bruno Victal (4): tests: xvnc: Fix test. marionette: Allow passing custom OCR arguments. tests: gdm: Prefer OCR to delay. tests: xvnc: Group up GDM test. gnu/build/marionette.scm | 34 +++++++++++++++++------- gnu/tests/gdm.scm | 19 ++++++++++---- gnu/tests/vnc.scm | 56 ++++++++++++++++++++-------------------- 3 files changed, 67 insertions(+), 42 deletions(-) base-commit: 94ac93042f09b4ba68b7b64ed1feeebd3dab1ea4