Message ID | cover.1687188729.git.graham@addis.org.uk |
---|---|
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 9BDF627BBE9; Mon, 19 Jun 2023 16:40:49 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 480CB27BBE2 for <patchwork@mira.cbaines.net>; Mon, 19 Jun 2023 16:40:49 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1qBGzi-0000Zk-NH; Mon, 19 Jun 2023 11:40:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1qBGyA-0000Im-04 for guix-patches@gnu.org; Mon, 19 Jun 2023 11:39:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1qBGy8-00082i-Oy; Mon, 19 Jun 2023 11:39:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1qBGy5-00032P-Oa; Mon, 19 Jun 2023 11:39:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64171] [PATCH 0/1] guix: pack: docker add docker-entry-point options Resent-From: Graham James Addis <grahamjamesaddis@gmail.com> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: mail@cbaines.net, dev@jpoiret.xyz, ludo@gnu.org, othacehe@gnu.org, rekado@elephly.net, zimon.toutoune@gmail.com, me@tobias.gr, guix-patches@gnu.org Resent-Date: Mon, 19 Jun 2023 15:39:01 +0000 Resent-Message-ID: <handler.64171.B.168718910711608@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64171 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 64171@debbugs.gnu.org Cc: Graham James Addis <graham@addis.org.uk>, Christopher Baines <mail@cbaines.net>, Josselin Poiret <dev@jpoiret.xyz>, Ludovic =?utf-8?q?Court=C3=A8s?= <ludo@gnu.org>, Mathieu Othacehe <othacehe@gnu.org>, Ricardo Wurmus <rekado@elephly.net>, Simon Tournier <zimon.toutoune@gmail.com>, Tobias Geerinckx-Rice <me@tobias.gr> X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Christopher Baines <mail@cbaines.net>, Josselin Poiret <dev@jpoiret.xyz>, Ludovic =?utf-8?q?Court=C3=A8s?= <ludo@gnu.org>, Mathieu Othacehe <othacehe@gnu.org>, Ricardo Wurmus <rekado@elephly.net>, Simon Tournier <zimon.toutoune@gmail.com>, Tobias Geerinckx-Rice <me@tobias.gr> Received: via spool by submit@debbugs.gnu.org id=B.168718910711608 (code B ref -1); Mon, 19 Jun 2023 15:39:01 +0000 Received: (at submit) by debbugs.gnu.org; 19 Jun 2023 15:38:27 +0000 Received: from localhost ([127.0.0.1]:57033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1qBGxX-00031A-GH for submit@debbugs.gnu.org; Mon, 19 Jun 2023 11:38:27 -0400 Received: from lists.gnu.org ([209.51.188.17]:52722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <grahamjamesaddis@gmail.com>) id 1qBGxW-000312-LF for submit@debbugs.gnu.org; Mon, 19 Jun 2023 11:38:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <grahamjamesaddis@gmail.com>) id 1qBGxV-0000FN-03 for guix-patches@gnu.org; Mon, 19 Jun 2023 11:38:25 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <grahamjamesaddis@gmail.com>) id 1qBGxQ-0007wy-7m for guix-patches@gnu.org; Mon, 19 Jun 2023 11:38:23 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-3f9b4a715d9so4090215e9.0 for <guix-patches@gnu.org>; Mon, 19 Jun 2023 08:38:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687189096; x=1689781096; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FI+hNte4KQ89X9MLPossu7pYNhz0kIRBjR7VmzayIjA=; b=EK2XuRaOmgwMFh/uVWoXSAirLQ/QqFPo6OPZAOYun5H1kH3ksoOj22XYREpDtChEzg 4bgaSXKMoqKwTVfBgLdEy67+YQK+zYGhdddTbI2nuYUEk5cZeiPZQgBbRoifoUvFhu1r L2kKh1g9NNo+qIWAVVZfTJuaWtJMCV2RWhcZ4MaTPAxxsXCs1wECtCmaj8X4v0dEqA5M euP4Xh5JPlT1kWqkzbyJst4HOQgyeBPnKgsJYkcrFrkXgT1o/ZoEcV1lrgUridgGdBZo y8oVYjJvwoEmx7k5kFYkAsnanijYN+5xBS6SgorUIulkf/tATlA/MV/G/BEXozHO5lWZ laUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687189096; x=1689781096; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FI+hNte4KQ89X9MLPossu7pYNhz0kIRBjR7VmzayIjA=; b=X3jxT1/QdrZTinKexhDFQRsdJObIzyZE8Qruwmu5Rp+BdocqFyPMf7fcrxiIlL8aWo aKazM3flUdhbdd6jy5438YI/Mm2vNDCv4KdEacB16qDo68kA1UJ4Rbxd0BKGeQnWP0M3 n4QCvfPKA2+vI70PePaAaiFZGVy6aRC5u6/qIO0/5jjWUHLOdy+1a5tzCd62SPouOehA DIKUHkn8ueIPcgn8jL4sHjnNAJaPcM6IH5Kr5lNlwLlZpDsil01S7xZ9FaapM7Tv4nzM ShQAfjcAXojc2+b89/P/XgTTQWdcCvCA/HRBbAHJ6OrvFdCmlsNvDrE841/CU4vMqVXl IpCA== X-Gm-Message-State: AC+VfDzBuGTbVTUb3eiB3DMxcZ40XDd1LLGG+elE7AN8iiAJR8DSl740 A7wEPMn3UhinydNnINNE0FBz4yioh3M= X-Google-Smtp-Source: ACHHUZ4XfSSe5xHyD92K38tcnpXFujM+FLCTlsvCdg6T+eFNvZQbqZmadDPybYEdBun6h4WwsEDAgA== X-Received: by 2002:a05:600c:2942:b0:3f7:e7a2:25f6 with SMTP id n2-20020a05600c294200b003f7e7a225f6mr7790404wmd.17.1687189096197; Mon, 19 Jun 2023 08:38:16 -0700 (PDT) Received: from guix-test.home ([2a00:23c7:59a9:c901:41c8:db68:b8b1:9808]) by smtp.gmail.com with ESMTPSA id y17-20020a1c4b11000000b003f7f249e7dfsm10306432wma.4.2023.06.19.08.38.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jun 2023 08:38:15 -0700 (PDT) From: Graham James Addis <grahamjamesaddis@gmail.com> X-Google-Original-From: Graham James Addis <graham@addis.org.uk> Date: Mon, 19 Jun 2023 16:37:59 +0100 Message-Id: <cover.1687188729.git.graham@addis.org.uk> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=grahamjamesaddis@gmail.com; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Mon, 19 Jun 2023 11:40:38 -0400 X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
guix: pack: docker add docker-entry-point options
|
|
Message
Graham James Addis
June 19, 2023, 3:37 p.m. UTC
This patch adds an option to guix pack to allow multiple parameters to be passed to the guix pack --format=docker command. Currently the although the --entry-point option can be entered multiple times, only the last entry is used as the docker ENTRYPOINT. Using the new --docker-entry-point option will take multiple entries and use them in the docker ENTRYPOINT exec form. Using --docker-entry-point will override any setting of --entry-point. The existing behaviour of --entry-point is retained if --docker-entry-point is not specified. Graham James Addis (1): guix: pack: docker add docker-entry-point options doc/guix.texi | 16 +++++- guix/scripts/pack.scm | 113 ++++++++++++++++++++++++++++++++---------- 2 files changed, 103 insertions(+), 26 deletions(-) base-commit: d884fc9e2efecfba09af4694f5a13ad7fc6f704f
Comments
Accidently included an emacs backup file in the patch submission. The correct bugs should be 64171 and 64173. This can be closed. On Mon, 19 Jun 2023 at 16:39, GNU bug Tracking System <help-debbugs@gnu.org> wrote: > > Thank you for filing a new bug report with debbugs.gnu.org. > > This is an automatically generated reply to let you know your message > has been received. > > Your message is being forwarded to the package maintainers and other > interested parties for their attention; they will reply in due course. > > As you requested using X-Debbugs-CC, your message was also forwarded to > Christopher Baines <mail@cbaines.net>, Josselin Poiret <dev@jpoiret.xyz>, Ludovic Courtès <ludo@gnu.org>, Mathieu Othacehe <othacehe@gnu.org>, Ricardo Wurmus <rekado@elephly.net>, Simon Tournier <zimon.toutoune@gmail.com>, Tobias Geerinckx-Rice <me@tobias.gr> > (after having been given a bug report number, if it did not have one). > > Your message has been sent to the package maintainer(s): > guix-patches@gnu.org > > If you wish to submit further information on this problem, please > send it to 64172@debbugs.gnu.org. > > Please do not send mail to help-debbugs@gnu.org unless you wish > to report a problem with the Bug-tracking system. > > -- > 64172: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64172 > GNU Bug Tracking System > Contact help-debbugs@gnu.org with problems
Hi, Graham James Addis <grahamjamesaddis@gmail.com> skribis: > This patch adds an option to guix pack to allow multiple parameters to > be passed to the guix pack --format=docker command. > > Currently the although the --entry-point option can be entered multiple > times, only the last entry is used as the docker ENTRYPOINT. > > Using the new --docker-entry-point option will take multiple entries > and use them in the docker ENTRYPOINT exec form. How about this alternative route: support multiple ‘--entry-point’ arguments. The first one is passed to the backend as #:entry-point (as is currently the case) and extra instances are passed as a list as #:entry-point-arguments. That way one could do: guix pack -f docker guile \ --entry-point=bin/guile --entry-point=--version Or, perhaps even better, introduce a new ‘--entry-point-argument’ (or ‘-A’) option. The advantage compared to ‘--docker-entry-point’ is that it could be supported by all the backends. WDYT? Thanks, Ludo’.
Hi Ludo, Happy to rework it either way. I can't think of any showstoppers off the top of my head. Which option would make the most sense? Thanks, Graham On Mon, 3 Jul 2023 at 10:26, Ludovic Courtès <ludo@gnu.org> wrote: > > Hi, > > Graham James Addis <grahamjamesaddis@gmail.com> skribis: > > > This patch adds an option to guix pack to allow multiple parameters to > > be passed to the guix pack --format=docker command. > > > > Currently the although the --entry-point option can be entered multiple > > times, only the last entry is used as the docker ENTRYPOINT. > > > > Using the new --docker-entry-point option will take multiple entries > > and use them in the docker ENTRYPOINT exec form. > > How about this alternative route: support multiple ‘--entry-point’ > arguments. The first one is passed to the backend as #:entry-point (as > is currently the case) and extra instances are passed as a list as > #:entry-point-arguments. > > That way one could do: > > guix pack -f docker guile \ > --entry-point=bin/guile --entry-point=--version > > Or, perhaps even better, introduce a new ‘--entry-point-argument’ (or > ‘-A’) option. > > The advantage compared to ‘--docker-entry-point’ is that it could be > supported by all the backends. > > WDYT? > > Thanks, > Ludo’.
Graham Addis <grahamjamesaddis@gmail.com> writes: > Hi Ludo, > > Happy to rework it either way. I can't think of any showstoppers off > the top of my head. > > Which option would make the most sense? [...] >> Or, perhaps even better, introduce a new ‘--entry-point-argument’ (or >> ‘-A’) option. IMO ‘--entry-point-argument’ is more semantic, its destination is clearer [...] Thanks a lot for this patch! Happy hacking, Gio'
One last question, as the proposed changes no longer reflect this bug description, should I raise a new bug, or just add the replacement patch to this one? On Mon, 3 Jul 2023 at 17:40, Giovanni Biscuolo <g@xelera.eu> wrote: > > Graham Addis <grahamjamesaddis@gmail.com> writes: > > > Hi Ludo, > > > > Happy to rework it either way. I can't think of any showstoppers off > > the top of my head. > > > > Which option would make the most sense? > > [...] > > >> Or, perhaps even better, introduce a new ‘--entry-point-argument’ (or > >> ‘-A’) option. > > IMO ‘--entry-point-argument’ is more semantic, its destination is clearer > > [...] > > Thanks a lot for this patch! > > Happy hacking, Gio' > > -- > Giovanni Biscuolo > > Xelera IT Infrastructures
Hi Graham, Graham Addis <grahamjamesaddis@gmail.com> writes: > One last question, as the proposed changes no longer reflect this bug > description, should I raise a new bug, or just add the replacement > patch to this one? You can retitle bugs on debbugs, have a look at [1]. [1] https://debbugs.gnu.org/server-control.html Best,