mbox series

[bug#63615,v2,0/2] Restyle and update xmrig to 6.19.2

Message ID cover.1684647790.git.a.r.draidi@redscript.org
Headers show
Series Restyle and update xmrig to 6.19.2 | expand

Message

Ahmad Draidi May 21, 2023, 5:48 a.m. UTC 
Version 2 fixes a few typos and grammatical mistakes in the description.
I spotted these after v1 was out. Sorry for the inconvenience.

Ahmad Draidi (2):
  gnu: xmrig: Run 'guix style' over the package.
  gnu: xmrig: Update to 6.19.2.

 gnu/packages/finance.scm | 74 ++++++++++++++++++----------------------
 1 file changed, 34 insertions(+), 40 deletions(-)


base-commit: 24b6f94cf9b4ab97ef2eb70d05b2104a06776e62

Comments

Guillaume Le Vaillant May 21, 2023, 8:30 a.m. UTC | #1 
I didn't apply patch 1, as the restyling doesn't seem necessary in this
case.
Patch 2 applied as 7b3f571fc8e3fbb3fefc30ebe53ad074c30653a8 with
a complete commit message.
Thanks.
A May 21, 2023, 8:53 a.m. UTC | #2 
Hello,

On 5/21/23 12:30, Guillaume Le Vaillant wrote:
> I didn't apply patch 1, as the restyling doesn't seem necessary in this
> case.
Out of curiosity, when would it be appropriate to send a "restyle" patch?
> Patch 2 applied as 7b3f571fc8e3fbb3fefc30ebe53ad074c30653a8 with
> a complete commit message.
> Thanks.
Thanks!
Guillaume Le Vaillant May 21, 2023, 11:23 a.m. UTC | #3 
A <a@redscript.org> skribis:

> Hello,
>
> On 5/21/23 12:30, Guillaume Le Vaillant wrote:
>> I didn't apply patch 1, as the restyling doesn't seem necessary in this
>> case.
> Out of curiosity, when would it be appropriate to send a "restyle" patch?
>> Patch 2 applied as 7b3f571fc8e3fbb3fefc30ebe53ad074c30653a8 with
>> a complete commit message.
>> Thanks.
> Thanks!

Restyling is usually done when a package is still using the old style
with labels for inputs, when it is using quasiquote forms for arguments
and using gexps would simplify things, or when it has very long lines
(more than 80 characters).