From patchwork Tue May 9 16:45:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josselin Poiret X-Patchwork-Id: 1483 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id C2BCA27BBED; Tue, 9 May 2023 17:46:22 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FROM_SUSPICIOUS_NTLD,MAILING_LIST_MULTI,PDS_OTHER_BAD_TLD, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id ECC4227BBEB for ; Tue, 9 May 2023 17:46:21 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwQTT-0004bp-UG; Tue, 09 May 2023 12:46:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwQTS-0004ax-Dp for guix-patches@gnu.org; Tue, 09 May 2023 12:46:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pwQTS-000278-4s for guix-patches@gnu.org; Tue, 09 May 2023 12:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pwQTR-00072W-Sb for guix-patches@gnu.org; Tue, 09 May 2023 12:46:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63314] [PATCH v2 0/2] Add PAM shepherd requirements Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 May 2023 16:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63314 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?utf-8?q?Court=C3=A8s?= , Josselin Poiret Cc: 63314@debbugs.gnu.org Received: via spool by 63314-submit@debbugs.gnu.org id=B63314.168365071526975 (code B ref 63314); Tue, 09 May 2023 16:46:01 +0000 Received: (at 63314) by debbugs.gnu.org; 9 May 2023 16:45:15 +0000 Received: from localhost ([127.0.0.1]:44288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwQSg-000710-UJ for submit@debbugs.gnu.org; Tue, 09 May 2023 12:45:15 -0400 Received: from jpoiret.xyz ([206.189.101.64]:55532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwQSd-00070e-Tg for 63314@debbugs.gnu.org; Tue, 09 May 2023 12:45:13 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 6359D184F1E; Tue, 9 May 2023 16:45:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1683650710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CtyjQNHpqmRTr92t8wLVA+XnEn/ZGbTCz3G1VzjbLAQ=; b=B123YAUCgmk8vBxU4H0Ra+VkitIfnBH9YYO7UGv9JEI2pHbsn5+vCcp7y/ov4pOU2qLCOX +JLcpQIPd99E5UyLJSdXNB94/QydTbn7iWblz54jrhn43e+sAOAT0/LaAvmvxXchM5OOwR QucgHq1ocYOJqmh3IHRLJI9iWjRmnXQigZ47vY0is7c+9hp+131Dnw4pCxL1/qAThaFCTc Vg3FUzW/f9qb5ziPBtsBUoW3jOA2qBO6MmWl+RyiHYgtgmrF2fgPiJMnivNfegraE6f0cV QkxHi6yLfW7Ml+pm1XfYgm37p6qb1TSUzbBmotHJuhpiLqY3fjGLQvEs0hOhSQ== Date: Tue, 9 May 2023 18:45:06 +0200 Message-Id: In-Reply-To: <87r0rrdun2.fsf_-_@gnu.org> References: <87r0rrdun2.fsf_-_@gnu.org> MIME-Version: 1.0 X-Spamd-Bar: ++++ Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Josselin Poiret X-ACL-Warn: , Josselin Poiret via Guix-patches X-Patchwork-Original-From: Josselin Poiret via Guix-patches via From: Josselin Poiret Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hi Ludo, Thanks for the review. Here is an updated patchset with the changes you requested. I don't think it's possible to have a reliable system test to check for the greetd issue, since it is a race problem in the end. Best, Josselin Poiret (2): system: pam: Let PAM extensions add shepherd requirements. services: elogind: Add elogind as a shepherd PAM requirement. gnu/services/authentication.scm | 28 ++++++------ gnu/services/base.scm | 54 +++++++++++----------- gnu/services/desktop.scm | 45 ++++++++++--------- gnu/services/kerberos.scm | 44 +++++++++--------- gnu/services/lightdm.scm | 2 +- gnu/services/mail.scm | 4 +- gnu/services/pam-mount.scm | 23 +++++----- gnu/services/sddm.scm | 2 +- gnu/services/ssh.scm | 10 +++-- gnu/services/xorg.scm | 4 +- gnu/system/pam.scm | 80 +++++++++++++++++++++++++++------ 11 files changed, 184 insertions(+), 112 deletions(-) base-commit: a759cbffafbf67b3a03c80b5bdbe3f3478affc50