From patchwork Sat Jan 28 13:30:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon South X-Patchwork-Id: 1230 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id B883727BBED; Sat, 28 Jan 2023 13:31:31 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 6EE9127BBE9 for ; Sat, 28 Jan 2023 13:31:26 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLlIP-0003dr-9s; Sat, 28 Jan 2023 08:31:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLlIM-0003bp-Ql for guix-patches@gnu.org; Sat, 28 Jan 2023 08:31:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pLlIM-0002Ak-Cr for guix-patches@gnu.org; Sat, 28 Jan 2023 08:31:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pLlIL-0007M8-Uv for guix-patches@gnu.org; Sat, 28 Jan 2023 08:31:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61120] [PATCH core-updates 0/1] gnu: mesa: Fix sporadic test failures. Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 28 Jan 2023 13:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61120 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 61120@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167491266028267 (code B ref -1); Sat, 28 Jan 2023 13:31:01 +0000 Received: (at submit) by debbugs.gnu.org; 28 Jan 2023 13:31:00 +0000 Received: from localhost ([127.0.0.1]:39890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLlIK-0007Lr-2i for submit@debbugs.gnu.org; Sat, 28 Jan 2023 08:31:00 -0500 Received: from lists.gnu.org ([209.51.188.17]:33418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLlIH-0007Lh-GV for submit@debbugs.gnu.org; Sat, 28 Jan 2023 08:30:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLlI8-0003ZQ-0p for guix-patches@gnu.org; Sat, 28 Jan 2023 08:30:49 -0500 Received: from mailout.easymail.ca ([64.68.200.34]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLlI4-00029U-Gi for guix-patches@gnu.org; Sat, 28 Jan 2023 08:30:47 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 18DD36813B for ; Sat, 28 Jan 2023 13:30:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo07-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo07-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dl80mrZakMtm for ; Sat, 28 Jan 2023 13:30:40 +0000 (UTC) Received: from localhost.localdomain (23-233-96-72.cpe.pppoe.ca [23.233.96.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 9E059680FB for ; Sat, 28 Jan 2023 13:30:40 +0000 (UTC) From: Simon South Date: Sat, 28 Jan 2023 08:30:38 -0500 Message-Id: X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Received-SPF: pass client-ip=64.68.200.34; envelope-from=simon@simonsouth.net; helo=mailout.easymail.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches On core-updates, I've found Mesa will sometimes fail its test suite with error messages like ../mesa-22.2.4/src/gallium/drivers/r600/sfn/tests/sfn_instrfromstring_test.cpp:712: Failure Expected equality of these values: os.str() Which is: "WRITE_SCRATCH 20 R1.xyzw\xFF\xFF AL:4 ALO:16" init Which is: "WRITE_SCRATCH 20 R1.xyzw AL:4 ALO:16" Turns out this is due to an uninitialized buffer in the test suite's code, reported to upstream with issue 7021[0] and fixed with upstream commit 7749599d[1] in Mesa 22.3.0. The patch to follow backports this commit to the version in core-updates, 22.2.4, and has eliminated these sporadic failures for me. Tested on x86-64 and AArch64 and everything seems fine. [0] https://gitlab.freedesktop.org/mesa/mesa/-/issues/7021 [1] https://gitlab.freedesktop.org/mesa/mesa/-/commit/7749599d737d205a88bbb6fa755ba095d9b581fa --- Simon South simon@simonsouth.net Simon South (1): gnu: mesa: Fix sporadic test failures. gnu/local.mk | 1 + gnu/packages/gl.scm | 4 ++- .../mesa-fix-sporadic-test-failures.patch | 27 +++++++++++++++++++ 3 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/mesa-fix-sporadic-test-failures.patch base-commit: 770d379d7b60590bfdcb749287cb6713dee093ce prerequisite-patch-id: 418e6f2f834e0f77d4da64e48bf654d610fbfe80 prerequisite-patch-id: 7c9321685c0c33cb9d1438797d2cb2bb540276c4