From patchwork Sat Jul 16 18:17:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roman Scherer X-Patchwork-Id: 262 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id B708727BBED; Sat, 16 Jul 2022 19:33:15 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 8521E27BBE9 for ; Sat, 16 Jul 2022 19:33:14 +0100 (BST) Received: from localhost ([::1]:34400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oCmbJ-00082J-F2 for patchwork@mira.cbaines.net; Sat, 16 Jul 2022 14:33:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCmPX-0005oG-6z for guix-patches@gnu.org; Sat, 16 Jul 2022 14:21:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48267) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oCmPV-00070o-U0 for guix-patches@gnu.org; Sat, 16 Jul 2022 14:21:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oCmPV-0002yS-Oq for guix-patches@gnu.org; Sat, 16 Jul 2022 14:21:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56604] [PATCH 0/8] Update Clojure to 1.11.1. Resent-From: r0man Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 16 Jul 2022 18:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56604 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 56604@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165799563211388 (code B ref -1); Sat, 16 Jul 2022 18:21:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Jul 2022 18:20:32 +0000 Received: from localhost ([127.0.0.1]:46026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCmP2-0002xc-3a for submit@debbugs.gnu.org; Sat, 16 Jul 2022 14:20:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:46812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCmMG-0002sa-Pm for submit@debbugs.gnu.org; Sat, 16 Jul 2022 14:17:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCmMG-0004ld-KL for guix-patches@gnu.org; Sat, 16 Jul 2022 14:17:40 -0400 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]:44912) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oCmME-0006J6-Nf for guix-patches@gnu.org; Sat, 16 Jul 2022 14:17:40 -0400 Received: by mail-ej1-x629.google.com with SMTP id ss3so14246121ejc.11 for ; Sat, 16 Jul 2022 11:17:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=burningswell-com.20210112.gappssmtp.com; s=20210112; h=from:to:subject:message-id:date:mime-version; bh=E9ZT5L587ActrgcZhdLPDaX9IrhKGeWIjqmBxhdRugI=; b=pCDIlwU5getxVqh4YTA12kf7sHKACZIDYQ7L30odJ2gB8vKyEjoA+0CZPv3XoqT0kD L6tFJhWsq+ixn51nhq3Nld/1hVrBJTf3NZcR3sWQAjBkHJECWmIBEYw7IIQS3Oe1d2gY mr6TvtAihxzdevT+KHhuAuJ5e16wcIkgl+3qOgGVqqUygMpw33V6V3nT32ey/LslLTES ecY5I2OsPEL4+KfiK91jQ5+3XlTWwBIQRf03rrkok8k4sM0DFjaLoTuzDVd9eIUWAFsq zZZqf4H5RSG7AMkpPrEFQBokWt62YA33FAxKaMiEiV27vtZ2DpLznbCjdigvjeSzNyVI Nylw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:message-id:date:mime-version; bh=E9ZT5L587ActrgcZhdLPDaX9IrhKGeWIjqmBxhdRugI=; b=GTh9sD0miMSEK5eQGIdSdXiLdgrUr2pqU0uVUl5hIOnUxjbrVsrgQg6KAQfSheuqIQ 2kCJLQ5n328JyJ3UUhuUuhOjd7Z3ZFDDYEDlzmvodbXlpfMmRJXzTFBJ9R7kEvuNTk1K akoM5qhNpVNDQFFqXvtzcSG76+JZVbfuYSP+ibCafP6Fw+PRmMgLTwX6mg5gzT3d9+9A HUgCKa7SXiMhihfsXQA9V/XgbBIOa5ZEpe1AuRmnqkImq6g10F58/NrZBIPFe5f90XyG dl0H13N0/xVtWIXi2Yz4n7tTjB38APz8tx9/t30DxMVYmt4VQFyxWGCEF1Y9HwuZa/OI 4/wA== X-Gm-Message-State: AJIora+747cwasZ4sjxdI8XST2cAWAK8sasegZ+XhKu44A/PrtHG1OrU l9MbG9yZ1YmYW19lMHtC4+bEL6tfqe04W1J0 X-Google-Smtp-Source: AGRyM1szxoWEpRQz5V5sDOQt2Y32WGS8mKXg3Nd6uSRwQliWt9Zc6b/wW3HXDiyPM+CEYc9hDT3Q3Q== X-Received: by 2002:a17:907:7209:b0:72b:924b:60a8 with SMTP id dr9-20020a170907720900b0072b924b60a8mr19765024ejc.442.1657995456528; Sat, 16 Jul 2022 11:17:36 -0700 (PDT) Received: from thinkpad (tmo-117-210.customers.d1-online.com. [80.187.117.210]) by smtp.gmail.com with ESMTPSA id j4-20020a170906474400b0072aed3b2158sm3475159ejs.45.2022.07.16.11.17.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Jul 2022 11:17:35 -0700 (PDT) From: r0man Message-Id: Date: Sat, 16 Jul 2022 20:17:34 +0200 MIME-Version: 1.0 Received-SPF: none client-ip=2a00:1450:4864:20::629; envelope-from=roman@burningswell.com; helo=mail-ej1-x629.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 16 Jul 2022 14:20:31 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Sat, 16 Jul 2022 14:32:24 -0400 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hello Guix, This patch series updates Clojure and it's packages to 1.11.1. It also adds the 'reset-class-timestamps phase to the Clojure build system. This phase makes sure the timestamp of compiled class files is set to a later point in time than the timestamp of the corresponding Clojure source files. If the timestamps of the class and source files are the same, the Clojure compiler will compile the sources again which can lead to issues. This problem has been discussed here [1]. The suggested solution was to keep/adjust the timestamps of the class files. [1] https://www.mail-archive.com/clojure@googlegroups.com/msg99928.html Could you please review this? In the patch for clojure-instaparse, I disabled the AOT compilation because of a known issue. Is that ok? Btw, I was a bit surprised that in Guix Clojure packages are AOT compiled. The general wisdom in the Clojure community seems to be to avoid AOT compilation when distributing libraries, and only AOT compiling Uberjars for final deployment. Due to issues like I mentioned in clojure-instaparse. Are we sure that AOT compiling all Clojure source files by default is a good idea, instead of just compiling user declared namespaces which Leiningen and friends are doing? WDYT? Thanks Roman. r0man (8): gnu: clojure-tools-cli: Update to 1.0.206. gnu: clojure-tools-gitlibs: Update to 2.4.181. gnu: clojure-tools-deps-alpha: Update to 0.14.1212. gnu: clojure-tools: Update to 1.11.1.1149. gnu: clojure: Update to 1.11.1. gnu: clojure-algo-generic: Fix test failing under AOT in Clojure 1.11.1. gnu: clojure-core-match: Update to 1.0.0. gnu: clojure-instaparse: Update to 1.4.12 (disabled AOT). gnu/packages/clojure.scm | 185 +++++++++++++++++++--------- guix/build/clojure-build-system.scm | 53 +++++++- 2 files changed, 178 insertions(+), 60 deletions(-) --- 2.36.1