| Message ID | cover.1649616716.git.h.goebel@crazy-compilers.com |
|---|---|
| Headers | show |
| Series | Add importer for hex.pm and rebar3 build-system for Erlang | expand |
Hartmut Goebel schreef op zo 10-04-2022 om 20:57 [+0200]: > * Shall the build system actually be called „rebar*3*“ or just „rebar“? There > is also a build-tool „rebar2“, which is obsoltete and not supported by this > build-system. Anyhow, somewhen in the future there might be some „rebar4“, > which we might be able to cover with the same build-system. WDYT? Was the rebar2 --> rebar3 change mostly backwards-compatible, and would a hypothetical rebar2 or rebar4 build system look mostly the same? If both hold, I would treat rebar2 --> rebar3 as ‘merely’ a package update from python@2 to python@3 -- some breaking changes, but no need for separate build systems (and hence, no 3 suffix) If rebar2, rebar3 and rebar4 would require completely different phases and use different file formats or such, IMO a separate build system (and hence, a 2, 3 or 4 suffix) may be useful. Greetings, Maxime.
Hi, Hartmut Goebel <h.goebel@crazy-compilers.com> skribis: > Thanks to Maxime Devos for the review of V3. Do ease review for other > reviewers, here is a complete set of updated patches, incorporating Maxime's > comments. Unless Maxime has further comments, this patch series looks ready to me, modulo the cosmetic changes I suggested (some of which can be made afterwards). Hartmut, can we remove guix/extracting-download.scm now? Thanks folks for all the work! Ludo’.
Ludovic Courtès schreef op vr 29-04-2022 om 15:18 [+0200]: > Hi, > > Hartmut Goebel <h.goebel@crazy-compilers.com> skribis: > > > Thanks to Maxime Devos for the review of V3. Do ease review for other > > reviewers, here is a complete set of updated patches, incorporating Maxime's > > comments. > > Unless Maxime has further comments, this patch series looks ready to me, > modulo the cosmetic changes I suggested (some of which can be made > afterwards). No further comments. Greetings, Maxime.
Am 11.04.22 um 14:04 schrieb Maxime Devos: > If rebar2, rebar3 and rebar4 would require completely different phases > and use different file formats or such, IMO a separate build system > (and hence, a 2, 3 or 4 suffix) may be useful. It took some time to come to a conclusion for me on this: I'm going to rename it into „rebar-build-system“ (without the number). If need arises for some rebar4-build-system, we can still think about adding „rebar3-build-system” as an alias. Rational: I assume, some rebar2 and rebar4 build-systems would have the same phases. „Just” commands might be different. Eg. rebar2 did just „compile“ while rebar3 can have „as prod compile“ — which could be handled with different means.
Hi Hartmut, Maxime Devos <maximedevos@telenet.be> skribis: > Ludovic Courtès schreef op vr 29-04-2022 om 15:18 [+0200]: >> Hi, >> >> Hartmut Goebel <h.goebel@crazy-compilers.com> skribis: >> >> > Thanks to Maxime Devos for the review of V3. Do ease review for other >> > reviewers, here is a complete set of updated patches, incorporating Maxime's >> > comments. >> >> Unless Maxime has further comments, this patch series looks ready to me, >> modulo the cosmetic changes I suggested (some of which can be made >> afterwards). > > No further comments. This patch series was reviewed and approved a while back, please feel free to push it! There were a couple of suggestions (non-blockers) that you could implement in subsequent patches. Thanks, Ludo’.
Many thanks for the review. Finally I finished this patch series and pushed as 9cccf6490d98bd40ea1eb9e84ecf4a2b32614107 Notable changes compared to last review comments: * removed guix extracting-download - which was an left-over * build-system is now named rebar (without '3') * fixed some minor lint-errors I also validated that all packages are up to date.
Hi, Hartmut Goebel <h.goebel@crazy-compilers.com> skribis: > Many thanks for the review. Finally I finished this patch series and > pushed as 9cccf6490d98bd40ea1eb9e84ecf4a2b32614107 Yay, well done, thanks! Ludo’.