mbox series

[bug#51543,v3,0/2] Some improvements to the Bash home service

Message ID cover.1636284793.git.public@yoctocell.xyz
Headers show
Series Some improvements to the Bash home service | expand

Message

Xinglu Chen Nov. 7, 2021, 11:36 a.m. UTC 
Changes since v2:

* Improve docstrings of ‘home-bash-extension’ fields by describing what
  they do instead of what they ought to be.

Xinglu Chen (2):
  home: services: bash: Add ‘aliases’ field.
  doc: Improve documentation of the Bash home service

 doc/guix.texi                |  60 ++++++++++++++++-
 gnu/home/services/shells.scm | 122 +++++++++++++++++++++++++----------
 guix/scripts/home/import.scm |  24 +++++++
 3 files changed, 169 insertions(+), 37 deletions(-)


base-commit: 1ffc0a6be3c1613b2d99ceea098174d1f11f6f3f

Comments

Ludovic Courtès Nov. 7, 2021, 8:58 p.m. UTC | #1 
Hello,

Xinglu Chen <public@yoctocell.xyz> skribis:

>   home: services: bash: Add ‘aliases’ field.
>   doc: Improve documentation of the Bash home service

Applied, thanks!

Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:

> The docstrings LGTM now.  This series is probably safe to go to master,
> though you might want to wait for people to complain about the addition
> of a field possibly breaking ABI and what not :P

Users won’t see any ABI breakage so I think we’re fine.  Applied!

Thanks Xinglu & Liliana!

Ludo’.
Ludovic Courtès Nov. 13, 2021, 8:35 p.m. UTC | #2 
Hi!

Xinglu Chen <public@yoctocell.xyz> skribis:

>   home: services: bash: Add ‘aliases’ field.
>   doc: Improve documentation of the Bash home service

I had overlooked it but it breaks tests/guix-home.sh and
tests/home-import.scm.  Could you take a look and send a patch in a new
issue?

Thanks,
Ludo’.