From patchwork Sun Aug 15 23:16:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sarah Morgensen X-Patchwork-Id: 269 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id E545927BC78; Mon, 16 Aug 2021 00:17:27 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id B28B327BC6B for ; Mon, 16 Aug 2021 00:17:27 +0100 (BST) Received: from localhost ([::1]:56624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFPNe-00078M-Ie for patchwork@mira.cbaines.net; Sun, 15 Aug 2021 19:17:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36296) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFPNH-00077P-9e for guix-patches@gnu.org; Sun, 15 Aug 2021 19:17:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36388) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mFPNG-00071J-OY for guix-patches@gnu.org; Sun, 15 Aug 2021 19:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mFPNG-0001cp-Kb for guix-patches@gnu.org; Sun, 15 Aug 2021 19:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50072] [PATCH WIP 0/4] Add upstream updater for git-fetch origins. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 15 Aug 2021 23:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50072 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 50072@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16290693886202 (code B ref -1); Sun, 15 Aug 2021 23:17:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Aug 2021 23:16:28 +0000 Received: from localhost ([127.0.0.1]:47934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFPMh-0001bx-Nf for submit@debbugs.gnu.org; Sun, 15 Aug 2021 19:16:28 -0400 Received: from lists.gnu.org ([209.51.188.17]:43464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFPMc-0001bd-Cj for submit@debbugs.gnu.org; Sun, 15 Aug 2021 19:16:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36232) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFPMc-0006ea-4h for guix-patches@gnu.org; Sun, 15 Aug 2021 19:16:22 -0400 Received: from out1.migadu.com ([91.121.223.63]:57916) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFPMZ-0006Xx-3S for guix-patches@gnu.org; Sun, 15 Aug 2021 19:16:21 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1629069376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=fdwVozHOIoneJWc/FOIByFwOsv6rNoZsKsHyUvUXw58=; b=A+Qy9yZJI/pZC9Vp8iOUn579Zfr53G1blnjXw5a1uTHWGOObbbD6zEJ7Hw95oLXdk7k+HO RmZK4Tg6B4eZ7NRV0uekaoOODK9GrY2mE2HYZFwYOqSUNsnrjZxMpmkVDVlshuBj6U/Ut4 NxcnFJDZ4mhBgj88kKpZ4LQJU7OOY20= From: Sarah Morgensen Date: Sun, 15 Aug 2021 16:16:13 -0700 Message-Id: MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev Received-SPF: pass client-ip=91.121.223.63; envelope-from=iskarian@mgsn.dev; helo=out1.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hello Guix, This is a proof-of-concept for extending `guix refresh -u` to support packages with git-fetch origins. The potential impact is large: approximately 4.5k packages use git-fetch, although only some fraction would be supported. Currently, this enables update support for (at least) any package where * github-updater finds an update, * origin-method is 'git-fetch', and * the package version is a suffix of the 'commit' field. Drawbacks currently include the fact that libgit2 doesn't (yet) support shallow checkouts [0], so the entire repository must be cloned. There is also no support for verifying commits. There should probably also be a few tests added. WDYT? [0] https://github.com/libgit2/libgit2/issues/3058 --- Sarah Morgensen (4): guix hash: Extract file hashing procedures. import: Factorize file hashing. refresh: Support non-tarball sources. upstream: Support updating git-fetch origins. guix/git-download.scm | 18 +++++++++++++- guix/hash.scm | 51 ++++++++++++++++++++++++++++++++++++++++ guix/import/cran.scm | 32 +++---------------------- guix/import/elpa.scm | 28 ++++------------------ guix/import/go.scm | 26 +++----------------- guix/scripts/hash.scm | 29 ++++++----------------- guix/scripts/refresh.scm | 10 ++++---- guix/upstream.scm | 41 +++++++++++++++++++++++++++++++- 8 files changed, 130 insertions(+), 105 deletions(-) create mode 100644 guix/hash.scm base-commit: 12099eac1b161d364be923451d27d7d739d0f14d