From patchwork Fri Jun 25 06:52:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sarah Morgensen X-Patchwork-Id: 187 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 832B027BC81; Fri, 25 Jun 2021 07:54:14 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_PASS,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 0975227BC78 for ; Fri, 25 Jun 2021 07:54:14 +0100 (BST) Received: from localhost ([::1]:44858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwfjA-0005Nt-V3 for patchwork@mira.cbaines.net; Fri, 25 Jun 2021 02:54:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwfj0-0005NL-Bc for guix-patches@gnu.org; Fri, 25 Jun 2021 02:54:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33145) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lwfj0-0001f9-4I for guix-patches@gnu.org; Fri, 25 Jun 2021 02:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lwfj0-0004Qv-4j for guix-patches@gnu.org; Fri, 25 Jun 2021 02:54:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49221] [PATCH 00/13] Add go-1.16 and build with gccgo Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 25 Jun 2021 06:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49221 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 49221@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.162460399116965 (code B ref -1); Fri, 25 Jun 2021 06:54:01 +0000 Received: (at submit) by debbugs.gnu.org; 25 Jun 2021 06:53:11 +0000 Received: from localhost ([127.0.0.1]:44688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwfiA-0004PZ-SQ for submit@debbugs.gnu.org; Fri, 25 Jun 2021 02:53:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:60576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwfi8-0004PR-O3 for submit@debbugs.gnu.org; Fri, 25 Jun 2021 02:53:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwfi8-0005Ko-D0 for guix-patches@gnu.org; Fri, 25 Jun 2021 02:53:08 -0400 Received: from out0.migadu.com ([2001:41d0:2:267::]:52528) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwfi4-0000zI-Bj for guix-patches@gnu.org; Fri, 25 Jun 2021 02:53:08 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1624603978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=EWpFjkI9A4KWAUsSvbMj9qsDbRsuH/jG6fxJagTZDv4=; b=UbFQPwaBuRzfOYU/RoaFG63sbtx5jL/jr3FBF5oWdy1mUk6FFk1184hOQCDjWRCY68NfLO V/pdqoGUe0ows1FEDuX5UwveWAEIUnQ/oeM0HyHUB1ryzjjVr3pvsFXG7retDRKAzBg9Dn GvGpNpi/Cog6tTz8Dxek0kXu6bjVtAQ= Date: Thu, 24 Jun 2021 23:52:55 -0700 Message-Id: MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev Received-SPF: pass client-ip=2001:41d0:2:267::; envelope-from=iskarian@mgsn.dev; helo=out0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: Sarah Morgensen X-ACL-Warn: , Sarah Morgensen via Guix-patches X-Patchwork-Original-From: Sarah Morgensen via Guix-patches via From: Sarah Morgensen X-getmail-retrieved-from-mailbox: Patches Hello Guix, This patch adds go 1.16, but does *not* make it the default for other packages which use go (as suggested in [2]). There have been a lot of changes between 1.14 and 1.16, and while I have fixed many issues, I am sure continued testing will uncover many more. This patch is based on [0], which adds gccgo-10. With this patch, go automatically bootstraps from gccgo[0][1] on platforms not supported by go 1.4, but you can do so on any platform with: guix build go --with-input=go@1.4-bootstrap-20171003=gccgo@10 Additionally, to build packages with 1.16: guix build --with-input=go@1.14=go@1.16 I would appreciate testing and feedback on the new bootstrap process, especially from powerpc64le users, as I have only been able to test on x86-64. (Note that it took about two hours for gccgo to build and 30 minutes for gccgo to build go.) Changes from 1.14: * Bootstrap with gccgo on platforms which do not support go 1.4 (see above) * Use GO_LDSO to set the interpreter rather than patching files * Fix typo in cgoldflags patch ("-rpath=" > "-Wl,-rpath=") * Fix and re-enable some cgo/gccgo tests * Remove references to perl (used for tests) to reduce closure size by 10% * Set GOCACHE so go doesn't complain that it can't access it $HOME * Break out tests into "check" phase so builders have more control I have successfully built and tested most go packages on x86-64, including restic, syncthing, chezmoi, and exercism. However... docker does not pass tests. It should probably be updated to 20.10, but it is a very complicated package and I do not have the skill to do so. I attempted to backport some of the fixes, but that was also beyond my abilities. Perhaps someone else will rise to the challenge? :) Sarah [0] [PATCH 0/1] gnu: Add gccgo-10. [1] Build go with gccgo [2] [PATCH] Added Go 1.16.2 Sarah Morgensen (13): gnu: go-github-com-puerkitobio-goquery: Update to 1.7.0. gnu: go-go-uber-org-atomic: Update to 1.8.0. gnu: go-github-com-sergi-go-diff: Update to 1.2.0. gnu: go-github-com-pelletier-go-toml: Update to 1.9.3. gnu: go-github-com-masterminds-goutils: Update to 1.1.1. gnu: go-github-com-magiconair-properties: Update to 1.8.5. gnu: go-github-com-dlclark-regexp2: Update to 1.4.0. gnu: earlyoom: Patch tests for go-1.16. gnu: go-github-com-bmatcuk-doublestar: Remove test incompatible with go-1.16. gnu: restic: Patch tests for go-1.16. gnu: go-gopkg-in-check-v1: Update to latest. gnu: go-etcd-io-bbolt: Update to 1.3.6. gnu: Add go-1.16. gnu/local.mk | 4 + gnu/packages/backup.scm | 5 +- gnu/packages/golang.scm | 243 +++++++++++++++--- gnu/packages/linux.scm | 4 +- .../earlyoom-1.6.2-disable-go-module.patch | 17 ++ .../patches/go-fix-script-tests.patch | 18 ++ ...m-bmatcuk-doublestar-1.3-remove-test.patch | 15 ++ .../restic-0.9.6-fix-tests-for-go1.15.patch | 51 ++++ 8 files changed, 314 insertions(+), 43 deletions(-) create mode 100644 gnu/packages/patches/earlyoom-1.6.2-disable-go-module.patch create mode 100644 gnu/packages/patches/go-fix-script-tests.patch create mode 100644 gnu/packages/patches/go-github-com-bmatcuk-doublestar-1.3-remove-test.patch create mode 100644 gnu/packages/patches/restic-0.9.6-fix-tests-for-go1.15.patch base-commit: c7804cd97b28ef012acc20c1d861904e9592382b prerequisite-patch-id: edb56de17ac3cce58402c83a9671b00381dfee76