| Message ID | cover.1617301221.git.public@yoctocell.xyz |
|---|---|
| Headers | show |
| Series | Add github-cli and dependencies | expand |
Friendly ping! :)
Am Montag, den 19.04.2021, 15:24 +0200 schrieb Xinglu Chen:
> Friendly ping! :)
I think you fixed most of my concerns from the previous run, but
looking at Patchwork, there appear to still be a few issues:
1. Some patches don't seem to apply correctly over at Patchwork [1].
This can perhaps be ignored, as it seems to be an issue with patches
being received out of order and the last one applies cleanly.
2. The corresponding revision fails to build [2].
3. The patch for safeexec still seems to be part of the series even
though it's unused. Didn't you mean to exclude that one?
Again, I'm not really familiar with the Go side of things, so while as
a reviewer I can point out stuff, that is not aesthetically pleasing,
as a committer I'm somewhat forced to trust what the CI tells me. I
would personally feel more reassured if someone with a bit of Go
experience had a look at this patch set, but judging from the 2 weeks
of silence, it seems they are all sleeping or silently trusting me to
do a good job.
Regards,
Leo
[1]
https://patches.guix-patches.cbaines.net/project/guix-patches/list/?series=7514
[2] https://data.guix-patches.cbaines.net/job/12256
On Mon, Apr 19 2021, Leo Prikler wrote: > Am Montag, den 19.04.2021, 15:24 +0200 schrieb Xinglu Chen: >> Friendly ping! :) > I think you fixed most of my concerns from the previous run, but > looking at Patchwork, there appear to still be a few issues: > > 1. Some patches don't seem to apply correctly over at Patchwork [1]. > This can perhaps be ignored, as it seems to be an issue with patches > being received out of order and the last one applies cleanly. Hmm, they applied on my local checkout, maybe it’s something to do with the order. > 2. The corresponding revision fails to build [2]. I will look into that. > 3. The patch for safeexec still seems to be part of the series even > though it's unused. Didn't you mean to exclude that one? Oops, not sure what I did there, it should be removed. > Again, I'm not really familiar with the Go side of things, so while as > a reviewer I can point out stuff, that is not aesthetically pleasing, > as a committer I'm somewhat forced to trust what the CI tells me. I > would personally feel more reassured if someone with a bit of Go > experience had a look at this patch set, but judging from the 2 weeks > of silence, it seems they are all sleeping or silently trusting me to > do a good job. Understood, thanks for taking a look!
Changes since v2: - Actually remove go-github-com-cli-safeexec Xinglu Chen (25): gnu: Add go-github-com-hinshun-vt10x. gnu: Add go-github-com-creack-pty. gnu: Add go-github-com-kr-pty. gnu: Add go-github-com-netflix-go-expect. gnu: Add go-github-com-alecaivazis-survey-v2. gnu: Add go-github-com-makenowjust-heredoc. gnu: Add go-github-com-briandowns-spinner. gnu: Add go-github-com-cli-browser. gnu: Add go-github-com-cli-oauth. gnu: Add go-github-com-russross-blackfriday-v2. gnu: Add go-github-com-cpuguy83-go-md2man-v2. gnu: Add go-github-com-enescakir-emoji. gnu: Add go-github-com-gabriel-vasile-mimetype. gnu: Add go-github-com-google-shlex. gnu: Add go-github-com-henvic-httpretty. gnu: Add go-github-com-itchyny-go-flags. gnu: Add go-github-com-itchyny-timefmt-go. gnu: Add go-github-com-itchyny-gojq. gnu: Add go-github-com-mattn-go-runewidth. gnu: Add go-github-com-rivo-uniseg. gnu: Add go-github-com-shurcool-githubv4. gnu: Add go-gopkg-in-yaml-v3. gnu: Add go-github-com-shurcool-graphql. gnu: Add go-github-com-cli-shurcool-graphql. gnu: Add github-cli. gnu/packages/golang.scm | 672 +++++++++++++++++++++++++++++++ gnu/packages/version-control.scm | 145 +++++++ 2 files changed, 817 insertions(+) base-commit: 1eb26d0e07ad439c935b324c1ed858f50e9dcccd