mbox series

[bug#51953,core-updates-frozen,0/2] Fix wlroots build with Meson 0.60.0

Message ID alpine.DEB.2.21.2111181142040.13935@marsh.hcoop.net
Headers show
Series Fix wlroots build with Meson 0.60.0 | expand

Message

Jack Hill Nov. 18, 2021, 4:43 p.m. UTC 
The build system now automatically detects which logind to use [0], and 
specifying the option is an error with Meson 0.60.0.

[0] https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/30308e35fac0491ab777495e2ee7e472378d375a

While I was modifying the package, I also updated its home-page to point 
to the new freedesktop.org location.

Jack Hill (2):
   gnu: wlroots: Remove logind-provider configure option.
   gnu: wlroots: Update home page.

  gnu/packages/wm.scm | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Josselin Poiret Nov. 18, 2021, 5:22 p.m. UTC | #1 
Jack Hill <jackhill@jackhill.us> writes:

> The build system now automatically detects which logind to use [0], and 
> specifying the option is an error with Meson 0.60.0.
>
> [0] https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/30308e35fac0491ab777495e2ee7e472378d375a

elogind is no longer a dependency of wlroots because of
https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/d50bbf0bbc49a9a8e010668cd357aba968ae884b
included in 0.14.

It is a dependency of seatd though, and it should be propagated because
it is required by the pkg-config of seatd.  Since you still specified
elogind here, pkg-config was able to find it nonetheless but this isn't
the proper way to do it.

Best,
Josselin Poiret
Jack Hill Nov. 19, 2021, 3:52 p.m. UTC | #2 
On Thu, 18 Nov 2021, Josselin Poiret via Guix-patches via wrote:

> Jack Hill <jackhill@jackhill.us> writes:
>
>> The build system now automatically detects which logind to use [0], and
>> specifying the option is an error with Meson 0.60.0.
>>
>> [0] https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/30308e35fac0491ab777495e2ee7e472378d375a
>
> elogind is no longer a dependency of wlroots because of
> https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/d50bbf0bbc49a9a8e010668cd357aba968ae884b
> included in 0.14.
>
> It is a dependency of seatd though, and it should be propagated because
> it is required by the pkg-config of seatd.  Since you still specified
> elogind here, pkg-config was able to find it nonetheless but this isn't
> the proper way to do it.

Ah, thanks for pointing that out, and submitted the proper fix in #51972.

I'm closing this issue.

Best,
Jack