mbox series

[bug#56238,0/2] : gnu: Add aoflagger

Message ID CAO+9K5p-3mAFXtHwKqTidGB-KOfGmUcbX970NBZ5=Xs1ctijpQ@mail.gmail.com
Headers show
Series : gnu: Add aoflagger | expand

Message

Sharlatan Hellseher June 26, 2022, 5:43 p.m. UTC 
Hi Guix team!

Here is a package depending on recently accepted Casacore - AOFlagger.
This series includes one source only package AOCommon, It's my first
time I packed  such package type, I hope I made it correct.

Sharlatan Hellseher (2):
  gnu: Add aocommon
  gnu: Add aoflagger

 gnu/packages/astronomy.scm                    | 90 +++++++++++++++++++
 ...flagger-use-system-provided-pybind11.patch | 38 ++++++++
 2 files changed, 128 insertions(+)
 create mode 100644
gnu/packages/patches/aoflagger-use-system-provided-pybind11.patch


base-commit: cbf02f10d7264d14accdc16b522077c8f857240f

--
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

Comments

Ludovic Courtès Aug. 4, 2022, 9:45 a.m. UTC | #1 
Hi!

Sharlatan Hellseher <sharlatanus@gmail.com> skribis:

>   gnu: Add aocommon
>   gnu: Add aoflagger

Finally applied, thanks!

I had to tweak a couple of things: change aocommon license to ‘gpl3+’
(since nothing says “version 3 only”), add missing #:use-module (guix
build-system copy), tweak description of aoflagger so it starts with an
actual sentence.

I took the liberty to remove timestamps like
“(Sharlatan-20220626T175728+0100)” from the comments: they’re
unnecessary (one can use ‘git annotate’), and given that repository
maintenance is a collective effort, having names associated with comment
doesn’t seem like a good idea.

Thanks,
Ludo’.