mbox series

[bug#51232,0/2] gnu: Update udiskie to 2.3.3

Message ID CALP7HJv-ynHeet6s=S9M0y0uNjskqT64QnBU-OwTa8hOz5RsQg@mail.gmail.com
Headers show
Series gnu: Update udiskie to 2.3.3 | expand

Message

Artem Chernyak Oct. 16, 2021, 3:30 a.m. UTC 
Since we now have libappindicator packaged, we can safely remove the
patch instead of updating it for the new version.

Artem Chernyak (2):
  gnu: Update udiskie to 2.3.3
  gnu: Remove udiskie-no-appindicator.patch

 gnu/packages/freedesktop.scm                  |   8 +-
 .../patches/udiskie-no-appindicator.patch     | 155 ------------------
 2 files changed, 3 insertions(+), 160 deletions(-)
 delete mode 100644 gnu/packages/patches/udiskie-no-appindicator.patch

Comments

Guillaume Le Vaillant Oct. 18, 2021, 9 a.m. UTC | #1 
Artem Chernyak <artemchernyak@gmail.com> skribis:

> Since we now have libappindicator packaged, we can safely remove the
> patch instead of updating it for the new version.
>
> Artem Chernyak (2):
>   gnu: Update udiskie to 2.3.3
>   gnu: Remove udiskie-no-appindicator.patch
>
>  gnu/packages/freedesktop.scm                  |   8 +-
>  .../patches/udiskie-no-appindicator.patch     | 155 ------------------
>  2 files changed, 3 insertions(+), 160 deletions(-)
>  delete mode 100644 gnu/packages/patches/udiskie-no-appindicator.patch

When removing a patch file, you must also remove it in the
'dist_patch_DATA' list of patches in the "gnu/local.mk" file.

Also, you don't need to split the patch removal in several commits (see
commit 2f0986b0f7cbf4dec5a3e575c67a508cf71c6dd5 for example).

Could you send an updated patch?