mbox series

[bug#45523,0/2] Update for frrouting & add libyang

Message ID CAEwRq=ofLk7kYYM5uV6srU8Ce6cF7W+xVwQa50Ah2tGEVX7Y7Q@mail.gmail.com
Headers show
Series Update for frrouting & add libyang | expand

Message

Vincent Legoll Dec. 29, 2020, 10:17 a.m. UTC 
The updated Frrouting needed some adaptations:

- packaging CESNET's libyang
- adding some dependencies (libcap, libyang, pcre for libyang)

I was not sure if I should have made pcre a
propagated-input in libyang instead of adding
it to frrouting or something like that.

I used the BSD-3 license for libyang, this should
be checked as I am not sure this is the right one.

Any feedback ?

Comments

Leo Famulari Dec. 31, 2020, 12:11 a.m. UTC | #1 
On Tue, Dec 29, 2020 at 11:17:54AM +0100, Vincent Legoll wrote:
> I was not sure if I should have made pcre a
> propagated-input in libyang instead of adding
> it to frrouting or something like that.

libyang includes pcre in the Requires.private field of libyang.pc.
According to the 'package reference' section of the Guix manual,
inputs should be propagated in this case:

https://guix.gnu.org/manual/en/html_node/package-Reference.html

> I used the BSD-3 license for libyang, this should
> be checked as I am not sure this is the right one.

(guix licenses) includes links to authoritative sources on licenses:

https://git.savannah.gnu.org/cgit/guix.git/tree/guix/licenses.scm#n167

You can check the package's LICENSE file against those resources.
Vincent Legoll Jan. 5, 2021, 11 a.m. UTC | #2 
The latet patch set removed pcre from
frrouting's inputs and modified libyang
to propagate this input.

The BSD-3 License should be the right
one in fact. As is is a Modified 3-clause
BSD.

Tchuss