mbox series

[bug#47513,00/12] Update jami and add jami-qt

Message ID 87y2e3kifn.fsf@gmail.com
Headers show
Series Update jami and add jami-qt | expand

Message

Maxim Cournoyer March 31, 2021, 5:14 a.m. UTC 
Hello!

I've finally picked up the packaging of Jami, which was becoming quite
outdated in Guix.  I haven't had much time to test the result yet, but a
priori it seems to function as intended.

Let me know how it works for you!

Maxim

Maxim Cournoyer (12):
  gnu: asio: Update to 1.18.1.
  gnu: restbed: Update to 4.7.
  gnu: restinio: Update to 0.6.13.
  gnu: Add nettle-3.7.
  gnu: opendht: Update to 2.2.0rc4.
  gnu: pjproject: Update to 2.11.
  gnu: pjproject-jami: Fix CVE-2020-15260 and CVE-2021-21375.
  ffmpeg-jami: Patch with the patches from Jami 20210326.1.cfba013.
  gnu: libring: Update to 20210326.1.cfba013.
  gnu: libringclient: Update to 20210326.1.cfba013.
  gnu: jami: Update to 20210326.1.cfba013 and rename to jami-gnome.
  gnu: Add jami-qt.

 gnu/local.mk                                |   1 -
 gnu/packages/emulators.scm                  |   2 +-
 gnu/packages/jami.scm                       | 287 ++++++++++++--------
 gnu/packages/nettle.scm                     |  17 +-
 gnu/packages/networking.scm                 | 131 +++++----
 gnu/packages/patches/opendht-fix-jami.patch |  33 ---
 gnu/packages/telephony.scm                  |  22 +-
 7 files changed, 272 insertions(+), 221 deletions(-)
 delete mode 100644 gnu/packages/patches/opendht-fix-jami.patch

Comments

M March 31, 2021, 6:49 a.m. UTC | #1 
On Wed, 2021-03-31 at 01:14 -0400, Maxim Cournoyer wrote:
> Hello!
> 
> I've finally picked up the packaging of Jami, which was becoming quite
> outdated in Guix.  I haven't had much time to test the result yet, but a
> priori it seems to function as intended.
> 
> Let me know how it works for you!

I read through the patch set and don't see any obvious problems.
Now I'll test this.

Greetings,
Maxime.
M March 31, 2021, 1:23 p.m. UTC | #2 
On Wed, 2021-03-31 at 01:14 -0400, Maxim Cournoyer wrote:
> Hello!
> 
> I've finally picked up the packaging of Jami, which was becoming quite
> outdated in Guix.  I haven't had much time to test the result yet, but a
> priori it seems to function as intended.
> 
> Let me know how it works for you!
> 
> Maxim

Something went wrong with sending the patch.
Snipped from first patch from
<https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47513#5>:

<start snip>
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: 47513@debbugs.gnu.org
Subject: [PATCH 01/12] gnu: asio: Update to 1.18.1.
Date: Wed, 31 Mar 2021 01:23:37 -0400
Message-Id: <20210331052348.5164-1-maxim.cournoyer@gmail.com>
X-Mailer: git-send-email 2.31.1
MIME-Version: 1.0
Content-Type: text/plain; charset=yes
Content-Transfer-Encoding: 8bit
<end snip>

What character encoding is 'yes'?
I manually changed 'yes' to 'utf-8' and only then the
patch series applied.

Now trying to build jami-gnome.

Greetings,
Maxime.
Maxim Cournoyer March 31, 2021, 4:57 p.m. UTC | #3 
Hi!

Maxime Devos <maximedevos@telenet.be> writes:

> On Wed, 2021-03-31 at 01:14 -0400, Maxim Cournoyer wrote:
>> Hello!
>> 
>> I've finally picked up the packaging of Jami, which was becoming quite
>> outdated in Guix.  I haven't had much time to test the result yet, but a
>> priori it seems to function as intended.
>> 
>> Let me know how it works for you!
>> 
>> Maxim
>
> Something went wrong with sending the patch.
> Snipped from first patch from
> <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47513#5>:
>
> <start snip>
> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
> To: 47513@debbugs.gnu.org
> Subject: [PATCH 01/12] gnu: asio: Update to 1.18.1.
> Date: Wed, 31 Mar 2021 01:23:37 -0400
> Message-Id: <20210331052348.5164-1-maxim.cournoyer@gmail.com>
> X-Mailer: git-send-email 2.31.1
> MIME-Version: 1.0
> Content-Type: text/plain; charset=yes
> Content-Transfer-Encoding: 8bit
> <end snip>
>
> What character encoding is 'yes'?
> I manually changed 'yes' to 'utf-8' and only then the
> patch series applied.

Oh, sorry about this!  I'm not sure what happened, as I generated the
series with 'git format-patch', and send it via 'git send-email',
without specifying any special options for the encoding.

I guess I simply replied 'yes' without reading through the questions git
send-email asked me (it was late :-)).

I'll resend the series now to spare anyone else the trouble of figuring
that out.

Thanks for letting me know!

> Now trying to build jami-gnome.

And for testing it!

Maxim
Maxim Cournoyer March 31, 2021, 5:23 p.m. UTC | #4 
Hi again,

Maxime Devos <maximedevos@telenet.be> writes:

> On Wed, 2021-03-31 at 01:14 -0400, Maxim Cournoyer wrote:
>> Hello!
>> 
>> I've finally picked up the packaging of Jami, which was becoming quite
>> outdated in Guix.  I haven't had much time to test the result yet, but a
>> priori it seems to function as intended.
>> 
>> Let me know how it works for you!
>> 
>> Maxim
>
> Something went wrong with sending the patch.
> Snipped from first patch from
> <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47513#5>:
>
> <start snip>
> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
> To: 47513@debbugs.gnu.org
> Subject: [PATCH 01/12] gnu: asio: Update to 1.18.1.
> Date: Wed, 31 Mar 2021 01:23:37 -0400
> Message-Id: <20210331052348.5164-1-maxim.cournoyer@gmail.com>
> X-Mailer: git-send-email 2.31.1
> MIME-Version: 1.0
> Content-Type: text/plain; charset=yes
> Content-Transfer-Encoding: 8bit
> <end snip>
>
> What character encoding is 'yes'?
> I manually changed 'yes' to 'utf-8' and only then the
> patch series applied.

Actually, retrying with the following command:

$ git send-email --to='47513@debbugs.gnu.org' [...] -v2 origin/master

again produces:

X-Mailer: git-send-email 2.31.1
MIME-Version: 1.0
Content-Type: text/plain; charset=yes
Content-Transfer-Encoding: 8bit

It had to do with:

$ git config sendemail.assume8bitEncoding
yes

I assumed this flag was a boolean but apparently it takes the encoding
type such as 'UTF-8'

After making this change:

--8<---------------cut here---------------start------------->8---
modified   git/.gitconfig
-	assume8bitEncoding = yes
+	assume8bitEncoding = utf-8
--8<---------------cut here---------------end--------------->8---

It shows up as utf-8, and hopefully will work better on your side!  I
just sent a v2.

Thanks for allowing me to realize this mistake of mine.

Maxim