mbox series

[bug#56813,0/2] Add a test for qemu-guest-agent service

Message ID 87y1wdb7yk.fsf@araneo.si
Headers show
Series Add a test for qemu-guest-agent service | expand

Message

Timotej Lazar July 28, 2022, 2:57 p.m. UTC 
Hi,

these patches fix some issues with the QEMU guest agent service, and add
a system test for it. The test runs the service in a marionette VM and
tries communicating with it. For that, I enabled the guest agent serial
device in marionette QEMU options. This change touches all system tests,
but should be harmless.

I’m not sure if it would be better instead to add a keyword argument to
make-marionette for (extra) extra QEMU options. In any case, all tests
that pass on master still pass after this change, at least on x86_64
(most installation tests currently fail here).

Please let me know if I should change or improve anything. Thanks!

Timotej Lazar (2):
  services: qemu-guest-agent: Fix arguments to qemu-ga.
  tests: Add qemu-guest-agent system test.

 gnu/build/marionette.scm        |  5 +-
 gnu/services/virtualization.scm | 12 ++---
 gnu/tests/virtualization.scm    | 84 +++++++++++++++++++++++++++++++++
 3 files changed, 93 insertions(+), 8 deletions(-)

Comments

Ludovic Courtès Aug. 9, 2022, 3:23 p.m. UTC | #1 
Hi Timotej,

Timotej Lazar <timotej.lazar@araneo.si> skribis:

> these patches fix some issues with the QEMU guest agent service, and add
> a system test for it. The test runs the service in a marionette VM and
> tries communicating with it. For that, I enabled the guest agent serial
> device in marionette QEMU options. This change touches all system tests,
> but should be harmless.

Yes, sounds good.

> I’m not sure if it would be better instead to add a keyword argument to
> make-marionette for (extra) extra QEMU options. In any case, all tests
> that pass on master still pass after this change, at least on x86_64
> (most installation tests currently fail here).

Perfect.

>   services: qemu-guest-agent: Fix arguments to qemu-ga.
>   tests: Add qemu-guest-agent system test.

Applied, thanks!

Ludo’.