From patchwork Sat Oct 12 21:25:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre Langlois X-Patchwork-Id: 15704 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 64E4F1749C; Sat, 12 Oct 2019 22:26:45 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id E3D90173D5 for ; Sat, 12 Oct 2019 22:26:44 +0100 (BST) Received: from localhost ([::1]:36134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJOuS-0001tf-0z for patchwork@mira.cbaines.net; Sat, 12 Oct 2019 17:26:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33939) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJOtr-0001tE-KU for guix-patches@gnu.org; Sat, 12 Oct 2019 17:26:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iJOto-0003FB-Dw for guix-patches@gnu.org; Sat, 12 Oct 2019 17:26:07 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53773) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iJOtn-0003F3-LK for guix-patches@gnu.org; Sat, 12 Oct 2019 17:26:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iJOtn-0004oO-Go for guix-patches@gnu.org; Sat, 12 Oct 2019 17:26:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#37720] [PATCH 0/2] gnu: easytag: Fix mp3 support. Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 12 Oct 2019 21:26:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 37720 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 37720@debbugs.gnu.org Cc: Pierre Langlois X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.157091555218475 (code B ref -1); Sat, 12 Oct 2019 21:26:03 +0000 Received: (at submit) by debbugs.gnu.org; 12 Oct 2019 21:25:52 +0000 Received: from localhost ([127.0.0.1]:34361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJOta-0004nt-7H for submit@debbugs.gnu.org; Sat, 12 Oct 2019 17:25:52 -0400 Received: from lists.gnu.org ([209.51.188.17]:50120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJOtW-0004nj-4r for submit@debbugs.gnu.org; Sat, 12 Oct 2019 17:25:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33896) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJOtU-0001p4-Qz for guix-patches@gnu.org; Sat, 12 Oct 2019 17:25:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iJOtR-000331-1r for guix-patches@gnu.org; Sat, 12 Oct 2019 17:25:44 -0400 Received: from mout.gmx.net ([212.227.17.20]:45161) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iJOtP-0002zd-VM for guix-patches@gnu.org; Sat, 12 Oct 2019 17:25:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1570915533; bh=cb/kEPX16T8dsMzYEywV4dDHuYia6AukbgdDHsr6ZAQ=; h=X-UI-Sender-Class:From:To:Subject:CC:Date; b=On/7b/ZV6Lq5h/QuKmJCf2vebzEMlGhVNei4E2oYzYZoDPOXbk26fvlYqBgYsb0ao BRxktSCtYFQ5PgfCO5h8MTXsXRT9EHrbq8ulpUhxG9F4DDgKRz8PjZckEksQBFTcha 7MAD5D/lw/GItApesWQZKkIsZhjjDVBw92uRIMQQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([2.99.192.73]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MQe5u-1iftYh0ypC-00NeeF; Sat, 12 Oct 2019 23:25:33 +0200 User-agent: mu4e 1.2.0; emacs 26.3 From: Pierre Langlois Date: Sat, 12 Oct 2019 22:25:31 +0100 Message-ID: <87tv8dy7uc.fsf@gmx.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:z+OkpGwGX1bgQQASaVxBqjwhpNX4RCpf4ltLUXjUkXUpCb3y3rk HN9svobZW6FYuRmclrMUf2ZEX2DEmLZCcedVxQ8NUmsq17MSOZl24iIg1lU8axlGHsccmav /daNcDzvSBUm74W/VyhOWnqVN0caWiw/lMJB4MDjjwgqS4SN/xman67qCL1m2wrfnXzfcHv z7R24GbcaGvTHA0xQFe6g== X-UI-Out-Filterresults: notjunk:1;V03:K0:LLl4db8FzzQ=:L9ffR/C7V/5vwJWeYv88XH lSYhK5KN03+s9FXA8fi3EMufYWYRy5XKfhd6VZUnxAv2HApc7GkJQz8R9WIomsehZBeLogNUM QLTs+WNcoRPextLd19B8ZgVxSsLtFgjY8gh4HPZGVlE6I/Rm8Ft5AqVkOfJ4wcvgQLr3w01LI HRXQotUBSBWFNhPEg3xBKRmVJbUX63UaBpDXjlqMZswsSEWd32WD9clnDAQrxkLii3LRFUY60 I9UE/VKbmOQRSO3yeUfZskvDmZhitPbl3Ze2X3NfJcfEm7iDHz9TgL4O4KiO8olZaDz94MJ9s Y2Z5CbFcngrIASwyZoiDsdNNDLN1VALfs5XhfaHXJa/P6kH0ezQso/y2GO8ugfRvyE96dc5DQ ZEBLitB/djEcXcK+JZ5vv5WU6DHCike8NtBEMvGDoB9jmTbsaSQUJJzNlMuyaK4LNgw1Poulh qEHdOkB3JM1yu3++nDn2FTnKe/JRM5vK1ysENGEAvy13DZvZ6+N2/oMPnOQb5ppA8H20XDuuG JLD6DNxYkTwtXdU0Lm6lmdH+O+OF3Nm8Fp4bQmDrX9kG/ArDUBgXzSge5bP8zDj8ooUIAtBg0 UCj35tIA/zWavUARRDhVkDfotekodVWnUJ42FyNxxSWCB5sB/MzXqzZCmFSU+GtuAxWVu7iqv joyuxNKtnm5PzIzNVIRJGEY1nzA1xh83Xn2wpn43CdG+G9VGrPpnBTAJJtp+swDJ8vEzxzcsx GylFCLQmjhY5YGKWwefCaRxhnBNgqHeV3Y1C5gWz6KZJZMiBvFbfJ6F3z8tk/tV4XA5azqPZV Xi7wsbOpL8IkZ8BGIxTNYurNVfyMNXECbsL0W94fMozeCc6+t58fEctQXMo5Oq2yflYMcppMu Sqwl4zuKx3AOTOX0sAe0n0BmfLXrA8t/HwbDubXQ1B5MZx/xNXcc6bIVp5mNy1p5xUvX4al+3 oNW7hvjiXD8auN1XceqXcTC7D1iWA7zdKP1HCtZ7HhPUeCDPPEGoA/c4hLIAsxj1IimhwJt0C UbF58xh/Z+20uGKcLhQq5eBPNeSK/ic2/TnlQE0QugdYczMZlHT3JZJvAla3/b1EysTtZZwMg JO/eX3FrkQcMiLhfpfpxGehZ2XaTIpUVpoEQzAyio2/K0a3LSqDg7KUsN6izwOAPHNj1uzxZx mc/oEeVF5Nu6bbvk9xmZc7lyjJnKxzDqUWfj6l4bJ7zgy5t663nCTP8nm/RHkPUnOeMD1IJZA kwuvrAC49B0bGaJvKorOjDcoy8emGX9ARsYgGbVpYgGFAFV5M4/kXsSaBKN8= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hello Guix! EasyTag hasn't been working for mp3 files and I couldn't work out why for a long time. I've finally got around to looking into it properly and it turns the hack with the temporary .pc file I added back then didn't work because it's missing some fields. With that fixed though, EasyTag warns you with a popup that id3lib is buggy and needs patching. It's something about UTF16 being broken: https://sourceforge.net/p/id3lib/patches/64/, I checked, ArchLinux also applies the same patch. WDYT? Pierre Langlois (2): gnu: id3lib: Apply patch for UTF16 writing bug. gnu: easytag: Fix mp3 support. gnu/local.mk | 1 + gnu/packages/mp3.scm | 5 ++- gnu/packages/music.scm | 12 ++++-- .../patches/id3lib-UTF16-writing-bug.patch | 39 +++++++++++++++++++ 4 files changed, 52 insertions(+), 5 deletions(-) create mode 100644 gnu/packages/patches/id3lib-UTF16-writing-bug.patch --- 2.23.0