| Message ID | 87tuk4mors.fsf@trop.in |
|---|---|
| Headers | show |
| Series | Essential home services | expand |
On 2021-08-05 08:41, Andrew Tropin wrote: > Seems there is no additional comments about implementation, so I just > send cosmetical changes treating comments from previous reviews. > > Changes since v3: > - Remove tabs. > - Move Home Services explanation from commit message to comment. > - Add missing ChangeLog-style commit body. > > Andrew Tropin (4): > home-services: Add most essential home services > home-services: Add home-run-on-change-service-type > home-services: Add home-provenance-service-type > home-services: Add fold-home-service-types function > > gnu/home-services.scm | 520 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 520 insertions(+) > create mode 100644 gnu/home-services.scm Guys, review v4 patches, please.
Hi Andrew,
Andrew Tropin <andrew@trop.in> writes:
[…]
> Guys, review v4 patches, please.
These patch series looks good for me.
As Ludovic suggested, we could move modules to another namespace for
code sharing, but it is not a blocker from merging changes and we could
do it later when we need to share the code. I think we should go
forward and push to the master. WDYT?
As I remember you have an access to push. Otherwise, please, ping me to
push it.<
Thanks,
Oleg.
On 2021-08-23 19:24, Oleg Pykhalov wrote: > Hi Andrew, > Hi Oleg! > > These patch series looks good for me. > > As Ludovic suggested, we could move modules to another namespace for > code sharing, but it is not a blocker from merging changes and we could > do it later when we need to share the code. I think we should go > forward and push to the master. WDYT? Yep, let's postpone moving modules to another namespace until it will be needed. Later, when the necessity appears, we will decide how to better organize the code. We can push it to master, but I planned to keep it in wip-guix-home for a while to bring all related stuff like documentation and cli to the branch and merge it to the master after everything is complete. Also, merging only part of Guix Home to the master will arise conflicts for users of rde channel (which contains current implementation of Guix Home). However, it is solvable by removing already merged parts from rde repository, so, it's not a big deal and I'm fine with both merging options. > > As I remember you have an access to push. Nope, I don't have commit access yet) > Otherwise, please, ping me to push it.< If everything seems ok, merge the changes, please. I'll prepare the next patch series soon. > > Thanks, > Oleg.
Andrew Tropin <andrew@trop.in> writes: […] >> As Ludovic suggested, we could move modules to another namespace for >> code sharing, but it is not a blocker from merging changes and we could >> do it later when we need to share the code. I think we should go >> forward and push to the master. WDYT? > > Yep, let's postpone moving modules to another namespace until it will be > needed. Later, when the necessity appears, we will decide how to better > organize the code. > > We can push it to master, but I planned to keep it in wip-guix-home for > a while to bring all related stuff like documentation and cli to the > branch and merge it to the master after everything is complete. > > Also, merging only part of Guix Home to the master will arise conflicts > for users of rde channel (which contains current implementation of Guix > Home). However, it is solvable by removing already merged parts from > rde repository, so, it's not a big deal and I'm fine with both merging > options. OK, pushed to the wip-guix-home. https://git.savannah.gnu.org/cgit/guix.git/?h=wip-guix-home
On 2021-08-24 15:14, Oleg Pykhalov wrote: > Andrew Tropin <andrew@trop.in> writes: > > […] > >>> As Ludovic suggested, we could move modules to another namespace for >>> code sharing, but it is not a blocker from merging changes and we could >>> do it later when we need to share the code. I think we should go >>> forward and push to the master. WDYT? >> >> Yep, let's postpone moving modules to another namespace until it will be >> needed. Later, when the necessity appears, we will decide how to better >> organize the code. >> >> We can push it to master, but I planned to keep it in wip-guix-home for >> a while to bring all related stuff like documentation and cli to the >> branch and merge it to the master after everything is complete. >> >> Also, merging only part of Guix Home to the master will arise conflicts >> for users of rde channel (which contains current implementation of Guix >> Home). However, it is solvable by removing already merged parts from >> rde repository, so, it's not a big deal and I'm fine with both merging >> options. > > OK, pushed to the wip-guix-home. > > https://git.savannah.gnu.org/cgit/guix.git/?h=wip-guix-home Thank you very much!) Sent a next patch for Guix Home. #50208