Message ID | 87il3df4y5.fsf@troyfigiel.com |
---|---|
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id CBB7727BBEA; Sun, 28 Jan 2024 22:51:18 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 6E20527BBE2 for <patchwork@mira.cbaines.net>; Sun, 28 Jan 2024 22:51:12 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1rUDzS-0004Sx-Sl; Sun, 28 Jan 2024 17:51:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rUDzK-0004Sb-OL for guix-patches@gnu.org; Sun, 28 Jan 2024 17:50:56 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rUDzK-0003tB-AB for guix-patches@gnu.org; Sun, 28 Jan 2024 17:50:54 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rUDzR-00047d-VO for guix-patches@gnu.org; Sun, 28 Jan 2024 17:51:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68789] [PATCH 0/2] gnu: Add python-pyjanitor. Resent-From: Troy Figiel <troy@troyfigiel.com> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 28 Jan 2024 22:51:01 +0000 Resent-Message-ID: <handler.68789.B.170648225615829@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 68789 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 68789@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.170648225615829 (code B ref -1); Sun, 28 Jan 2024 22:51:01 +0000 Received: (at submit) by debbugs.gnu.org; 28 Jan 2024 22:50:56 +0000 Received: from localhost ([127.0.0.1]:58565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1rUDzM-00047F-1z for submit@debbugs.gnu.org; Sun, 28 Jan 2024 17:50:56 -0500 Received: from lists.gnu.org ([2001:470:142::17]:59702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <troy@troyfigiel.com>) id 1rUDzK-000471-AL for submit@debbugs.gnu.org; Sun, 28 Jan 2024 17:50:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <troy@troyfigiel.com>) id 1rUDz4-0004S2-R8 for guix-patches@gnu.org; Sun, 28 Jan 2024 17:50:38 -0500 Received: from mout-p-103.mailbox.org ([2001:67c:2050:0:465::103]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from <troy@troyfigiel.com>) id 1rUDz3-0003rZ-1T for guix-patches@gnu.org; Sun, 28 Jan 2024 17:50:38 -0500 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4TNRTy4sVqz9sWl for <guix-patches@gnu.org>; Sun, 28 Jan 2024 23:50:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=troyfigiel.com; s=MBO0001; t=1706482230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=I/facY1ZjN47gYS2bc3CWNTwrmokIyWT/S1irU2D81Q=; b=LSTK+uvSUfWSo2iw9oaqFNdG+2254lQ7PGkZ5QJkyNaEHz/NpnE+aSVUxB45GbxXmbDqDd /klyhWVjL0wYG7MusrKt0lejsA68WwVDH8WDHQwKgFABF8XkPwacSrkO4a0kmQY/9dt6SO brKuHkoFvJLl7P1bgG3AAao/hR0iqA/osicH7589/DDaDw6zeiCHEIz2dtpJby9YJJs3Xc wbb7bNxbFrBz0R8N+pbXtQBjCGlI63NNB4LF9bjL/R+nUcGp48qnI4SlyNb8g2u3Mza2qD oHK3S31zyAZ1jfQhuuJpWrShHfusea7dSgYM3RRIYiTANqreSSGZHlCY6VatKw== From: Troy Figiel <troy@troyfigiel.com> Date: Sun, 28 Jan 2024 23:49:30 +0100 Message-ID: <87il3df4y5.fsf@troyfigiel.com> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 4TNRTy4sVqz9sWl Received-SPF: pass client-ip=2001:67c:2050:0:465::103; envelope-from=troy@troyfigiel.com; helo=mout-p-103.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
gnu: Add python-pyjanitor.
|
|
Message
Troy Figiel
Jan. 28, 2024, 10:49 p.m. UTC
This patch series adds python-pyjanitor and its dependency python-unyt. Troy Figiel (2): gnu: Add python-unyt. gnu: Add python-pyjanitor. gnu/packages/python-science.scm | 88 +++++++++++++++++++++++++++++++++ 1 file changed, 88 insertions(+) base-commit: 08ed3ec64ecd571d92d497b2493f5c0225102c99
Comments
Hi Troy, Thank you for the patches! I'm in the process of packaging python-yt in (gnu packages astronomy) and I've noticed that python-unyt is part of it which brought me here :-) I started reviewing this issue so. One note - you introduced a module cycle which was not before astronomy->python-science->astronomy. If the requirement of python-astropy is soft let's silent it for now. Also I've already updated the whole chain depending on python-astropy after it's update to 6.0.0, letting you know if your work requires fresh Astropy version. It will be in review on 20th next month. What do you think? Regards, Oleg
Hi Oleg, Thanks for the check! On 2024-01-29 15:26, Sharlatan Hellseher wrote: > One note - you introduced a module cycle which was not before > astronomy->python-science->astronomy. If the requirement of > python-astropy is soft let's silent it for now. Removing the python-astropy dependency should be fine for python-unyt. I agree that avoiding module cycles would be better. If I recall correctly, Astropy was only used in tests, because it has a similar submodule dealing with physical units. The build was successful and the cycle did not show up in the linter. How did you find it? Did you happen to notice it when you saw the imports? Best wishes, Troy
Hi,
How did you find it? Did you happen to notice it when you saw the imports?
>
It's usually pops up in issues with efforts to break modules cycles
e.g. https://issues.guix.gnu.org/54539.
I'm not quite sure how it is critical right now, but there was a discussion
that cycles in modules slow down ~guix pull~.
Let's comment astropy out with some notes about optional test dependency
and potential module cycle.
Looking forward for v2, patches look good.
If you have wider plan of upcoming patches please share to coordinate
efforts ;-).
Regards,
Oleg
Now that you mention it, there are quite a few cycles. To name a few: - astronomy->python-science->python-xyz->astronomy - databases->python-xyz->databases - bioinformatics->python-science->bioinformatics On 2024-01-29 18:31, Sharlatan Hellseher wrote: > If you have wider plan of upcoming patches please share to coordinate > efforts ;-). There is only the guix-devel list, right? No Python specific list? When it comes to the Python ecosystem, I have been looking at - python-shap - python-cocotb (#68153) - ruff Unfortunately, ruff has caused me some headaches since it uses a Rust workspace definition. I will probably have to write guix-devel for advice sooner or later. I've also still had some Golang packages on my radar, since long-term I would like to see opentofu and gotenberg included. That might be going off-topic a bit :-)
Modifications applied: - python-unyt :: rephrase description, partly sourced and combined from <https://packages.debian.org/sid/python3-unyt>, <https://unyt.readthedocs.io/en/stable/> - python-pyjanitor :: speed up tests with python-pytest-xdist (~x3 faster on 16x threads), remove blank lines, disable exact tests related to PySpark. Pushed as 370b79b4f5..cde0adaacd to master. Thanks, Oleg