mbox series

[bug#34246,0/3] Improve the upower-service style.

Message ID 877eenqy8f.fsf@cbaines.net
Headers show
Series Improve the upower-service style. | expand

Message

Christopher Baines Jan. 29, 2019, 3:28 p.m. UTC 
These patches update the style of the upower-service. Improving and
documenting the <upower-configuration> record, and deprecating the
upower-service procedure.

Directly using record types as default values for service types, along
with default values for the fields in the record type is generally more
flexible and configurable than using procedures for service
configuration. It means that the configuration for the service can be
changed programatically by generating new configuration based off of the
original configuration, rather than having to rerun the procedure that
created the configuration in the first place.


Christopher Baines (3):
  services: Improve the upower-configuration record.
  services: Improve the upower-service-type.
  services: desktop: Deprecate the upower-service procedure.

 doc/guix.texi            | 79 ++++++++++++++++++++++++++--------
 gnu/services/desktop.scm | 92 +++++++++++++++++++++++++++-------------
 2 files changed, 123 insertions(+), 48 deletions(-)

Comments

Ludovic Courtès Feb. 16, 2019, 9:30 p.m. UTC | #1 
Hello!

Christopher Baines <mail@cbaines.net> skribis:

> These patches update the style of the upower-service. Improving and
> documenting the <upower-configuration> record, and deprecating the
> upower-service procedure.
>
> Directly using record types as default values for service types, along
> with default values for the fields in the record type is generally more
> flexible and configurable than using procedures for service
> configuration. It means that the configuration for the service can be
> changed programatically by generating new configuration based off of the
> original configuration, rather than having to rerun the procedure that
> created the configuration in the first place.
>
>
> Christopher Baines (3):
>   services: Improve the upower-configuration record.
>   services: Improve the upower-service-type.
>   services: desktop: Deprecate the upower-service procedure.

All three patches LGTM.  Thanks for taking the time to do this!  :-)

Ludo’.
Christopher Baines Feb. 16, 2019, 10:15 p.m. UTC | #2 
Ludovic Courtès <ludo@gnu.org> writes:

> Hello!
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> These patches update the style of the upower-service. Improving and
>> documenting the <upower-configuration> record, and deprecating the
>> upower-service procedure.
>>
>> Directly using record types as default values for service types, along
>> with default values for the fields in the record type is generally more
>> flexible and configurable than using procedures for service
>> configuration. It means that the configuration for the service can be
>> changed programatically by generating new configuration based off of the
>> original configuration, rather than having to rerun the procedure that
>> created the configuration in the first place.
>>
>>
>> Christopher Baines (3):
>>   services: Improve the upower-configuration record.
>>   services: Improve the upower-service-type.
>>   services: desktop: Deprecate the upower-service procedure.
>
> All three patches LGTM.  Thanks for taking the time to do this!  :-)

Great, I've pushed these patches to master now :)