mbox series

[bug#35028,0/3] Remove WebKitGTK from GNOME Shell closure

Message ID 877ecj7ksh.fsf@ngyro.com
Headers show
Series Remove WebKitGTK from GNOME Shell closure | expand

Message

Timothy Sample March 28, 2019, 3:14 a.m. UTC
Hi Guix,

This patch set removes WebKitGTK from the GNOME Shell closure, making it
way smaller.  I built all the dependants of “evolution-data-server” and
“gnome-online-accounts”, fixing the inputs as I went.  I also tested a
few things in a virtual machine.  Everything seems good to me, but it is
hard to tell what might break subtly with something like
“gnome-online-accounts”.  I did make sure that the GNOME Control Center
still worked after having removed it as an input to GNOME Shell.  I’m
not sure why it was there in the first place.

Timothy Sample (3):
  gnu: gnome-online-accounts: Split off 'lib' output.
  gnu: evolution-data-server: Add 'libedataserverui' output.
  gnu: gnome-shell: Remove gnome-control-center from inputs.

 gnu/packages/gnome.scm | 71 ++++++++++++++++++++++++++++++++++++------
 1 file changed, 62 insertions(+), 9 deletions(-)


-- Tim

Comments

Ludovic Courtès March 30, 2019, 2:19 p.m. UTC | #1
Hi Timothy,

Timothy Sample <samplet@ngyro.com> skribis:

> This patch set removes WebKitGTK from the GNOME Shell closure, making it
> way smaller.  I built all the dependants of “evolution-data-server” and
> “gnome-online-accounts”, fixing the inputs as I went.  I also tested a
> few things in a virtual machine.  Everything seems good to me, but it is
> hard to tell what might break subtly with something like
> “gnome-online-accounts”.  I did make sure that the GNOME Control Center
> still worked after having removed it as an input to GNOME Shell.  I’m
> not sure why it was there in the first place.
>
> Timothy Sample (3):
>   gnu: gnome-online-accounts: Split off 'lib' output.
>   gnu: evolution-data-server: Add 'libedataserverui' output.
>   gnu: gnome-shell: Remove gnome-control-center from inputs.

I’ve applied it all and also tested in a VM.  It looks good!

Thank you!

BTW, we should probably give you commit access.  Would you like to
create an account on Savannah and upload your OpenPGP key there?

Ludo’.
Timothy Sample April 13, 2019, 5:49 p.m. UTC | #2
Hi Ludo,

Ludovic Courtès <ludo@gnu.org> writes:

> Hi Timothy,
>
> Timothy Sample <samplet@ngyro.com> skribis:
>
>> This patch set removes WebKitGTK from the GNOME Shell closure, making it
>> way smaller.  I built all the dependants of “evolution-data-server” and
>> “gnome-online-accounts”, fixing the inputs as I went.  I also tested a
>> few things in a virtual machine.  Everything seems good to me, but it is
>> hard to tell what might break subtly with something like
>> “gnome-online-accounts”.  I did make sure that the GNOME Control Center
>> still worked after having removed it as an input to GNOME Shell.  I’m
>> not sure why it was there in the first place.
>>
>> Timothy Sample (3):
>>   gnu: gnome-online-accounts: Split off 'lib' output.
>>   gnu: evolution-data-server: Add 'libedataserverui' output.
>>   gnu: gnome-shell: Remove gnome-control-center from inputs.
>
> I’ve applied it all and also tested in a VM.  It looks good!
>
> Thank you!
>
> BTW, we should probably give you commit access.  Would you like to
> create an account on Savannah and upload your OpenPGP key there?

Sorry for the delay.

That would be cool!  I put my GPG key on Savannah.  My username is
“samplet”: <https://savannah.gnu.org/users/samplet>.


-- Tim
Ludovic Courtès April 14, 2019, 5:44 p.m. UTC | #3
Hi Timothy!

Timothy Sample <samplet@ngyro.com> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:

[...]

>> BTW, we should probably give you commit access.  Would you like to
>> create an account on Savannah and upload your OpenPGP key there?
>
> Sorry for the delay.
>
> That would be cool!  I put my GPG key on Savannah.  My username is
> “samplet”: <https://savannah.gnu.org/users/samplet>.

Awesome, I’ve added you.  Could you reply to this message signed with
that key?

Please read ‘HACKING’ for the rules for commit access, and also, feel
empowered to review and push patches.

Thank you, and welcome aboard!  :-)

Ludo’.
Timothy Sample April 15, 2019, 12:18 a.m. UTC | #4
Ludovic Courtès <ludo@gnu.org> writes:

> Hi Timothy!
>
> Timothy Sample <samplet@ngyro.com> skribis:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>
> [...]
>
>>> BTW, we should probably give you commit access.  Would you like to
>>> create an account on Savannah and upload your OpenPGP key there?
>>
>> Sorry for the delay.
>>
>> That would be cool!  I put my GPG key on Savannah.  My username is
>> “samplet”: <https://savannah.gnu.org/users/samplet>.
>
> Awesome, I’ve added you.  Could you reply to this message signed with
> that key?

Ack.

> Please read ‘HACKING’ for the rules for commit access, and also, feel
> empowered to review and push patches.

I already have a few simple packages in mind that I could submit or
update, so this is great.

> Thank you, and welcome aboard!  :-)

Thank you!


-- Tim