mbox series

[bug#50327,0/2] Improved ‘free disk space’ message + a question

Message ID 875yvkaymg.fsf@nckx
Headers show
Series Improved ‘free disk space’ message + a question | expand

Message

Tobias Geerinckx-Rice Sept. 1, 2021, 7:05 p.m. UTC
Guix,

This improves the warning given when free space looks sus.

From:

  note: build failure may have been caused by lack of free disk 
  space

to:

  note: only 0.01 MiB available in ‘/gnu/store’
  note: only 5.00 MiB available in ‘/tmp/guix-build-foo.drv-0’
  note: build failure may have been caused by lack of free disk 
  space

It also raises the warning threshold from 8 to 64 MiB, which is a 
much prettier arbitrary integer.

Question: shouldn't all of nix/ have licence headers added too? 
As it stands, there are two very lonely ones in 
nix/libstore/builtins.{cc,hh} and that's it.

Kind regards,

T G-R

Comments

Ludovic Courtès Sept. 18, 2021, 9:55 a.m. UTC | #1
Hi,

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> This improves the warning given when free space looks sus.
>
> From:
>
>  note: build failure may have been caused by lack of free disk   space
>
> to:
>
>  note: only 0.01 MiB available in ‘/gnu/store’
>  note: only 5.00 MiB available in ‘/tmp/guix-build-foo.drv-0’
>  note: build failure may have been caused by lack of free disk   space
>
> It also raises the warning threshold from 8 to 64 MiB, which is a much
> prettier arbitrary integer.

LGTM.  :-)

Eventually we should i18n messages coming from the daemon.

> Question: shouldn't all of nix/ have licence headers added too? As it
> stands, there are two very lonely ones in
> nix/libstore/builtins.{cc,hh} and that's it.

Yeah well, they were taken as-is from Nix.  I wouldn’t bother,
especially since we wouldn’t what copyright holders to list in there.

Thanks!

Ludo’.