From patchwork Thu Jan 6 17:45:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liliana Marie Prikler X-Patchwork-Id: 548 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 2C19127BBEA; Thu, 6 Jan 2022 18:25:46 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 6276527BBE9 for ; Thu, 6 Jan 2022 18:25:45 +0000 (GMT) Received: from localhost ([::1]:40416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5XSK-0006JT-H1 for patchwork@mira.cbaines.net; Thu, 06 Jan 2022 13:25:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60642) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5XRe-0006JD-B2 for guix-patches@gnu.org; Thu, 06 Jan 2022 13:25:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49294) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5XRe-0000WE-1I for guix-patches@gnu.org; Thu, 06 Jan 2022 13:25:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5XRd-0004xk-ST for guix-patches@gnu.org; Thu, 06 Jan 2022 13:25:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v8 00/41] guix: node-build-system: Support compiling add-ons with node-gyp. References: <20211114124151.36743-1-philip@philipmcgrath.com> In-Reply-To: <20211114124151.36743-1-philip@philipmcgrath.com> Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 06 Jan 2022 18:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath Cc: 51838@debbugs.gnu.org, Timothy Sample , Pierre Langlois , Jelle Licht , Leo Famulari Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.164149346618743 (code B ref 51838); Thu, 06 Jan 2022 18:25:01 +0000 Received: (at 51838) by debbugs.gnu.org; 6 Jan 2022 18:24:26 +0000 Received: from localhost ([127.0.0.1]:42145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5XR2-0004rz-Pw for submit@debbugs.gnu.org; Thu, 06 Jan 2022 13:24:26 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:44756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5XR0-0004rV-OQ for 51838@debbugs.gnu.org; Thu, 06 Jan 2022 13:24:23 -0500 Received: by mail-wr1-f67.google.com with SMTP id k18so6444589wrg.11 for <51838@debbugs.gnu.org>; Thu, 06 Jan 2022 10:24:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:date:subject:to:cc:content-transfer-encoding:message-id :mime-version; bh=bocJkcTXA3eC5HYaLInBmZqZlhpffwj3nZvTwSmok00=; b=VYmpi9Zm/pISPsiaKLofRnGcMzDLRxF2whPLyP6c+qxu7teaOR/GFDf5CSXSukvKCB hIzXZqeQ6fYkHk26J3SxVdPT5wi8cz6VP53an8zEBk68o9aaG1pCTN5W3NtNRfW9G1ai 0abTM4DaWIFXtacda3COhtjdvr5b8K72KgP7NJxmUit7oay8gV9V0q79yVaQ/QARCMuM iUmeftpNzjgdDzTrMyN5lNYOXudzVcDYdOgdthORFny0LK13vMQZFAwmenjw/v3rMN/c fevhIWBhn23SRqqeW6DoIJbH950OYHcxGe57oBg4slJIf9o38ZR/nDeb0wwPWjZbuJoc h5Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:subject:to:cc :content-transfer-encoding:message-id:mime-version; bh=bocJkcTXA3eC5HYaLInBmZqZlhpffwj3nZvTwSmok00=; b=tNw+49vh1kYdShZqUC+ZKqTdfGFLRY1epO5sxraspN0NWiYnk5CAxs53JDmwSE6F+6 Rmi5X7y8tdhqRDWJtnvgR9uBTpGh1Qh8f/M7Hp118Q5k200YIun6wwF97hFis+4nOjh/ IgafIeiC96SGgpeO9hSH3K3wzNU7wgQMBBNo08rqZ1Oh/at7pqCv573cGjw7bhgRD8SD yZvJPCekZmnxrcbAMrlhNmYjiLaLt7grmPjyXVqF6SLqlRn1syVZvtC5TdDAAQNuVTpx 0Y67oYZkVJVJqINQqUIrTbYaMWg5BVcX12CGkSMmczHVBT0S31wHAeINVEBCFbFIvWPu bcJg== X-Gm-Message-State: AOAM530NA0GFxfOyJ3UrsPpRiN9lqcn5GhP3DMBFV/+/07Om87IL3ENS lXzCbt/q0OUXhJlOntOo6V8= X-Google-Smtp-Source: ABdhPJyX5hU2QnwSyuj92ZMmgCI/Uo7dEdrrB6XQr/o2Xb+hXxz+q8Nhy7zIalwlKsPhSDphK3E0PA== X-Received: by 2002:a5d:584f:: with SMTP id i15mr54006171wrf.542.1641493456745; Thu, 06 Jan 2022 10:24:16 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id b17sm2693311wrq.91.2022.01.06.10.24.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jan 2022 10:24:16 -0800 (PST) From: Liliana Marie Prikler Date: Thu, 6 Jan 2022 18:45:40 +0100 Message-ID: <64e08d3a1838ed8507f33fae895545372960522f.camel@gmail.com> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Philip, Please pardon the large flood of messages in a short enough of time without waiting for a reply. I tried my best to come up with a v8 that addresses my personal concerns quickly. My main changes were to patches 3-5, but note how deleting dependencies became significantly easier in 6pp. To list the main differences: 1. I've implemented the alist/JSON utilities in terms of SRFI-1 and SRFI-71. 2. I shortened the additional JSON API to jsobject-ref and jsobject-update*. I still believe alist->json-object and json-object->alist would be more useful (in particular, the main operation of jsobject-union is actually alist-flatten), but I digress. 3. I made it so that delete-dependencies also acts on peerDependencies. That way, we don't have to dance around ordering. 4. Regexps :) If there's anything you'd like to say about this v8, feel free to do so. As always, there's the waiting time of at least 14 days, which I plan to adhere to. Cheers, Liliana PS: If someone else wants to push these in my absence, please adjust the signoffs. Also, if those mail headers are broken, don't forget to reset Philip as author. Philip McGrath (41): guix: node-build-system: Add delete-lockfiles phase. guix: node-build-system: Add implicit libuv input. guix: node-build-system: Add JSON utilities. guix: node-build-system: Add avoid-node-gyp-rebuild phase. guix: node-build-system: Add 'delete-dependencies' helper function. gnu: node-semver-bootstrap: Use 'delete-dependencies'. gnu: node-ms-bootstrap: Use 'delete-dependencies'. gnu: node-binary-search-bootstrap: Use 'delete-dependencies'. gnu: node-debug-bootstrap: Use 'delete-dependencies'. gnu: node-llparse-builder-bootstrap: Use 'delete-dependencies'. gnu: node-llparse-frontend-bootstrap: Use 'delete-dependencies'. gnu: node-llparse-bootstrap: Use 'delete-dependencies'. gnu: node-semver: Use 'delete-dependencies'. gnu: node-wrappy: Use 'delete-dependencies'. gnu: node-once: Use 'delete-dependencies'. gnu: node-irc-colors: Use 'delete-dependencies'. gnu: node-irc: Use 'delete-dependencies'. gnu: Add node-inherits. gnu: Add node-safe-buffer. gnu: Add node-string-decoder. gnu: Add node-readable-stream. gnu: Add node-nan. gnu: Add node-openzwave-shared. gnu: Add node-addon-api. gnu: Add node-sqlite3. gnu: Add node-file-uri-to-path. gnu: Add node-bindings. gnu: Add node-segfault-handler. gnu: Add node-ms. gnu: Add node-debug. gnu: Add node-serialport-binding-abstract. gnu: Add node-serialport-parser-delimiter. gnu: Add node-serialport-parser-readline. gnu: Add node-serialport-bindings. gnu: Add node-serialport-parser-regex. gnu: Add node-serialport-parser-ready. gnu: Add node-serialport-parser-inter-byte-timeout. gnu: Add node-serialport-parser-cctalk. gnu: Add node-serialport-parser-byte-length. gnu: Add node-serialport-stream. gnu: Add node-serialport. gnu/packages/node-xyz.scm | 942 ++++++++++++++++++++++++++++++- gnu/packages/node.scm | 56 +- gnu/packages/zwave.scm | 64 +++ guix/build-system/node.scm | 9 +- guix/build/node-build-system.scm | 236 +++++++- 5 files changed, 1247 insertions(+), 60 deletions(-)