mbox series

[bug#78837,ruby-team,0/3] Almost there!

Message ID 20250619083315.1881-1-ngraves@ngraves.fr
Headers
Series Almost there! |

Message

Nicolas Graves June 19, 2025, 8:32 a.m. UTC 
  Now that I don't have locally failing tests, let's try and address tests that fail on CI.

Nicolas Graves (3):
  gnu: ruby-puma: Skip additional failing test.
  gnu: ruby-minitest-stub-const: Add minitest native-input.
  gnu: ruby-spy: Skip problematic test.

 gnu/packages/ruby-xyz.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Christopher Baines June 19, 2025, 9:45 a.m. UTC | #1 
Nicolas Graves via Guix-patches via <guix-patches@gnu.org> writes:

> Now that I don't have locally failing tests, let's try and address tests that fail on CI.
>
> Nicolas Graves (3):
>   gnu: ruby-puma: Skip additional failing test.
>   gnu: ruby-minitest-stub-const: Add minitest native-input.
>   gnu: ruby-spy: Skip problematic test.
>
>  gnu/packages/ruby-xyz.scm | 9 +++++++++
>  1 file changed, 9 insertions(+)

Hmm, I can build all of these locally. Maybe some of the tests are flaky
but I'm tempted to wait until QA has caught up.

I'm most unsure about the ruby-minitest-stub-const change, that seems to
be building on CI as well https://ci.guix.gnu.org/build/11337230/details
Nicolas Graves June 19, 2025, 12:17 p.m. UTC | #2 
On 2025-06-19 10:45, Christopher Baines wrote:

> Nicolas Graves via Guix-patches via <guix-patches@gnu.org> writes:
>
>> Now that I don't have locally failing tests, let's try and address tests that fail on CI.
>>
> Hmm, I can build all of these locally. Maybe some of the tests are flaky
> but I'm tempted to wait until QA has caught up.
>
> I'm most unsure about the ruby-minitest-stub-const change, that seems to
> be building on CI as well
> https://ci.guix.gnu.org/build/11337230/details

Maybe I'm not looking at the right place? Usually what I do is I look at
the dashboard of the last evaluation of the branch :
https://ci.guix.gnu.org/eval/2065235/dashboard

then I type in "ruby-" to focus on those, and I still see ruby-spy,
ruby-puma failing for some reason.

What am I doing wrong?