mbox series

[bug#78066,0/2] Fix fail2ban build

Message ID 20250425201230.12492-1-rodion@goritskov.com
Headers
Series Fix fail2ban build |

Message

Rodion Goritskov April 25, 2025, 8:12 p.m. UTC 
  Hi!

Currently fail2ban is not building [1] because its test suite is not compatible with Python 3.11.
Quick fix is to use Python 3.10 there.

Probably I will find some time to update fail2ban package in the nearest future
(because it is quite old now, four years passed already).

However, I think it is good to have the current version building for now.

[1] - https://issues.guix.gnu.org/77996

Rodion Goritskov (2):
  gnu: python: Export wrap-python3.
  gnu: fail2ban: Build with Python 3.10.

 gnu/packages/admin.scm  | 3 ++-
 gnu/packages/python.scm | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

Comments

Nicolas Graves April 26, 2025, 2:59 p.m. UTC | #1 
Hi Rodion!

I think the issue with using a different Python version is that I'm not
sure it behaves well in a profile, since python packages are propagated.
Maybe the CLI might work well, but importing python modules would
probably be broken.

If it's only the tests that are broken, maybe it's better to ignore
failing tests?

Or even better : simply update the package to a more recent version.  I
get the impression that it should work well from
https://github.com/fail2ban/fail2ban/releases/tag/1.1.0

I'll see if such an update fixes your issue, if yes I'll send an update
here.
Nicolas Graves April 27, 2025, 6:29 a.m. UTC | #2 
I managed to get tests to pass properly with an update and minimal
changes (but a change in the build-system [1], I still have to replace
the install phase to avoid a world-rebuild).  The subject with
fail2ban is that there's also a complete config, and since I'm not a
user, I'm not sure everything will work well there.  But let's update
it, and modify the fail2ban configuration if things have changed there.

See you in a few minutes/hours when I'll send an updated patch series!

[1]: https://lists.gnu.org/archive/html/guix-devel/2025-04/msg00332.html

On 2025-04-26 16:59, Nicolas Graves via Guix-patches via wrote:

> Hi Rodion!
>
> I think the issue with using a different Python version is that I'm not
> sure it behaves well in a profile, since python packages are propagated.
> Maybe the CLI might work well, but importing python modules would
> probably be broken.
>
> If it's only the tests that are broken, maybe it's better to ignore
> failing tests?
>
> Or even better : simply update the package to a more recent version.  I
> get the impression that it should work well from
> https://github.com/fail2ban/fail2ban/releases/tag/1.1.0
>
> I'll see if such an update fixes your issue, if yes I'll send an update
> here.