mbox series

[bug#72071,0/2] A clean series of patches

Message ID 20240729173604.220603-1-luca.cirrottola@inria.fr
Headers
Series A clean series of patches |

Message

Luca Cirrottola July 29, 2024, 5:36 p.m. UTC 
  Hello Ludo', following your suggestion, I have implemented a simpler
solution that just skips off the problematic test (without moving
around files). I send a new patch series with the full modifications
to be applied to the recipe, containing one commit for the package
version update, and one commit for skipping the test.

Let me know if it looks better (no pressure).

Thanks,
Luca

Luca Cirrottola (2):
  Solve issue https://issues.guix.gnu.org/68313 by updating HDF5 version
    to 1.14.3 (containing the official fix
    https://github.com/HDFGroup/hdf5/pull/3421).
  Skip test_check_version since the patch-settings phase needs to modify
    the test reference file.

 gnu/packages/maths.scm | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

Comments

Ludovic Courtès Aug. 19, 2024, 10:37 a.m. UTC | #1 
Hi Luca,

Luca Cirrottola <luca.cirrottola@inria.fr> skribis:

> Hello Ludo', following your suggestion, I have implemented a simpler
> solution that just skips off the problematic test (without moving
> around files). I send a new patch series with the full modifications
> to be applied to the recipe, containing one commit for the package
> version update, and one commit for skipping the test.
>
> Let me know if it looks better (no pressure).
>
> Thanks,
> Luca
>
> Luca Cirrottola (2):
>   Solve issue https://issues.guix.gnu.org/68313 by updating HDF5 version
>     to 1.14.3 (containing the official fix
>     https://github.com/HDFGroup/hdf5/pull/3421).
>   Skip test_check_version since the patch-settings phase needs to modify
>     the test reference file.

I reorganized the changes a bit; in particular, since skipping the test
is necessary for 1.14.3 to build, I squashed the upgrade and the test
skip in the same commit.

Also, the test change would break hdf@1.8, so I moved that to hdf@1.14.

The result is:

  84c62cf166 * gnu: hdf5-parallel-openmpi: Update to 1.14.x.
  832f2bcb92 * gnu: hdf5@1.14: Update to 1.14.3.

Tested with:

  ./pre-inst-env guix build --no-grafts \
    hdf5@1.8 hdf5@1.14 hdf5-parallel-openmpi hdf5@1.10

Thanks!

Ludo’.