From patchwork Fri Aug 11 09:03:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ulfvonbelow X-Patchwork-Id: 1132 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 3165927BBE9; Fri, 11 Aug 2023 10:05:25 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 37C2D27BBE2 for ; Fri, 11 Aug 2023 10:05:23 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUO4w-0000dO-TT; Fri, 11 Aug 2023 05:05:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUO4t-0000dA-TH for guix-patches@gnu.org; Fri, 11 Aug 2023 05:05:04 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qUO4s-0005t3-Ba for guix-patches@gnu.org; Fri, 11 Aug 2023 05:05:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qUO4s-0005sS-6J for guix-patches@gnu.org; Fri, 11 Aug 2023 05:05:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65221] [PATCH 0/2] Fix EXTRA-PORTS edge cases Resent-From: ulfvonbelow Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Aug 2023 09:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 65221 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 65221@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.169174465522533 (code B ref -1); Fri, 11 Aug 2023 09:05:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Aug 2023 09:04:15 +0000 Received: from localhost ([127.0.0.1]:44886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUO46-0005rN-V8 for submit@debbugs.gnu.org; Fri, 11 Aug 2023 05:04:15 -0400 Received: from lists.gnu.org ([2001:470:142::17]:34610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUO42-0005r5-BO for submit@debbugs.gnu.org; Fri, 11 Aug 2023 05:04:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUO3w-0000Zh-I3 for guix-patches@gnu.org; Fri, 11 Aug 2023 05:04:04 -0400 Received: from tilde.club ([142.44.150.184]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUO3u-0005pR-Vl for guix-patches@gnu.org; Fri, 11 Aug 2023 05:04:04 -0400 Received: by tilde.club (Postfix, from userid 5378) id 0F9D9224F4692; Fri, 11 Aug 2023 09:04:00 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 tilde.club 0F9D9224F4692 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tilde.club; s=mail; t=1691744640; bh=linGC3kD3douhiErQdIdFJMfzkwkn0WJIIfccp4fbVc=; h=From:To:Subject:Date:From; b=dwON6zgNyQwXwdwnspw4J2TQUKDP8GSSGXL//UYDq1IvnFF0vaQ+zvNSnpfgjDlkW taI5N3XqXZ3u0j89NrK2DoGaMk+G6jLvNGwMEs/NmxWO/qUptWOX7smGTyxXNspJhU 86RjfeQbVCBUI16KUsuRNEJYCfQ6vD5YZBYmxm+g= From: ulfvonbelow Date: Fri, 11 Aug 2023 04:03:52 -0500 Message-Id: <20230811090352.3572-1-striness@tilde.club> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Received-SPF: pass client-ip=142.44.150.184; envelope-from=striness@tilde.club; helo=tilde.club X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches The #:extra-ports argument to exec-command and its users behaves quite strangely in certain circumstances, for example when multiple ports are supplied, and they are supplied in an order other than by ascending file descriptor number. This can cause file descriptors to be clobbered. ulfvonbelow (2): service: make EXTRA-PORTS work as advertised. service: use PRESERVE-PORTS for redirecting FDs 0-2. modules/shepherd/service.scm | 119 ++++++++++++++++++++++------------- 1 file changed, 76 insertions(+), 43 deletions(-)