From patchwork Fri Apr 7 14:05:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 1409 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 5C70517418; Fri, 7 Apr 2023 15:07:24 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 8B8F5173D2 for ; Fri, 7 Apr 2023 15:07:23 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pkmk8-0004Cr-P9; Fri, 07 Apr 2023 10:07:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkmk2-0004CJ-CG for guix-patches@gnu.org; Fri, 07 Apr 2023 10:07:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pkmk2-00033k-4L for guix-patches@gnu.org; Fri, 07 Apr 2023 10:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pkmk1-0003Uk-OT; Fri, 07 Apr 2023 10:07:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62712] [PATCH 0/2] Disable keyword expansion for Subversion downloads Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: samplet@ngyro.com, zimon.toutoune@gmail.com, guix-patches@gnu.org Resent-Date: Fri, 07 Apr 2023 14:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 62712 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 62712@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= , Timothy Sample , zimoun X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Timothy Sample , zimoun Received: via spool by submit@debbugs.gnu.org id=B.168087636813239 (code B ref -1); Fri, 07 Apr 2023 14:07:01 +0000 Received: (at submit) by debbugs.gnu.org; 7 Apr 2023 14:06:08 +0000 Received: from localhost ([127.0.0.1]:56943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkmj9-0003RR-W4 for submit@debbugs.gnu.org; Fri, 07 Apr 2023 10:06:08 -0400 Received: from lists.gnu.org ([209.51.188.17]:38796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkmj7-0003R9-R6 for submit@debbugs.gnu.org; Fri, 07 Apr 2023 10:06:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkmj7-00044n-FL for guix-patches@gnu.org; Fri, 07 Apr 2023 10:06:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkmj6-0002v2-M1; Fri, 07 Apr 2023 10:06:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=cWlmENraqsPJYREFIMSOaWM8IxkCu/5zojV3MyRYjII=; b=Il06KWFkH9nK4+ JRMgSBfmqlTM0Z3fIhhZoWwhGNDPn3c14AT/P2Jy+dFA4kON4hlKPV83NA8wNhQHIGnHdLyL4nBCQ VvgWDBxvGrulHi8L5CKSw1bcKSMLrkC3D1qh1vR8q8Gnq0A/V4t/9H87lX1gjhaZSaCQJuqwwomul 2r2Ixn9DzNVcXmDBjQB31fm0yXDvwhhfFZXxjwQsmwgcxBpfYHiRqPlRZgZbcT1H+/PUdmSkOW1aP urhSdpKXUDcv4r1XyZ2jm/GUs+2sMgMQQVzlqjKz8dZwGZHonnqePv/pVlvkw5r0fHTATg7aY5167 P0HPMPm+r/aU1gE62qkA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pkmj1-0006P9-I5; Fri, 07 Apr 2023 10:06:03 -0400 From: Ludovic =?utf-8?q?Court=C3=A8s?= Date: Fri, 7 Apr 2023 16:05:51 +0200 Message-Id: <20230407140551.8776-1-ludo@gnu.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hello Guix! As discussed in , SVN keyword expansion during checkout is problematic because it depends on local timezone. This in itself isn't really a problem in Guix because the timezone in the environment of fixed-output derivations is always UTC. However, SWH disables keyword expansion (for this reason), and thus it makes sense to follow suit. Disabling keyword expansion entails many rebuilds. However, these are "safe", so I'd like to have them on a branch (or simply handled by qa.guix) that we'd merge as soon as it's built. The second patch makes ‘recursive?’ default to #f, which AFAICS is what all the SVN-using packages that were not explicit expected (no changes required). Thoughts? Ludo’. Ludovic Courtès (2): svn-download: Disable keyword expansion. svn-download: Default to non-recursive checkouts. gnu/packages/java.scm | 2 +- gnu/packages/machine-learning.scm | 2 +- gnu/packages/tex.scm | 16 ++++++++-------- gnu/packages/video.scm | 4 ++-- guix/build/svn.scm | 9 ++++++++- guix/svn-download.scm | 6 +++--- 6 files changed, 23 insertions(+), 16 deletions(-) base-commit: 47fe66586e0fbc177288ec91cc88ea0b081505b0