mbox series

[bug#62702,0/2] : gnu wsjtx: Update to 2.6.1 and improve style.

Message ID 20230406213157.27820-1-sharlatanus@gmail.com
Headers
Series : gnu wsjtx: Update to 2.6.1 and improve style. |

Message

Sharlatan Hellseher April 6, 2023, 9:31 p.m. UTC 
Hi Guix!

I've started a long journey to enable Qt6 for Stellarium. But at first I
need to rename "qtserialport" to "qtserialport-5" and pack new "qtserialport"
based on Qt6.

This patch series provides one of many future updates and adjustments of
projects where "qtserialport" is in use to make sure they are not failing to
build.

Sharlatan Hellseher (2):
  gnu: wsjtx: Update to 2.6.1.
  gnu: wsjtx: Improve package style.

 gnu/packages/radio.scm | 32 ++++++++++++++++++--------------
 1 file changed, 18 insertions(+), 14 deletions(-)

Comments

Leo Famulari April 13, 2023, 3:07 a.m. UTC | #1 
On Thu, Apr 06, 2023 at 10:31:57PM +0100, Sharlatan Hellseher wrote:
> Hi Guix!
> 
> I've started a long journey to enable Qt6 for Stellarium. But at first I
> need to rename "qtserialport" to "qtserialport-5" and pack new "qtserialport"
> based on Qt6.
> 
> This patch series provides one of many future updates and adjustments of
> projects where "qtserialport" is in use to make sure they are not failing to
> build.

Thanks for working on this project and taking care of the details!

Pushed as 982698c52fb388e278dc4cec4b124406f23f102a
Sharlatan Hellseher April 13, 2023, 9:02 p.m. UTC | #2 
Hi Leo,

Thanks for review and suggestions. I've ended up by splitting my
initial patch into 3 to increase visibility of the changes.

Sharlatan Hellseher (3):
  gnu: packages music: Delete use-module duplicates.
  gnu: packages music: Sort use-module alphabetically.
  gnu: abjad: Fix build.

 gnu/packages/music.scm | 96 +++++++++++++++++++++---------------------
 1 file changed, 48 insertions(+), 48 deletions(-)


base-commit: c371555a4b46a5c9288f54753b0f158f9c4b8abc
-- 
2.39.2


-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.
Leo Famulari April 14, 2023, 5:56 p.m. UTC | #3 
On Thu, Apr 13, 2023 at 10:02:04PM +0100, Sharlatan Hellseher wrote:
> Hi Leo,
> 
> Thanks for review and suggestions. I've ended up by splitting my
> initial patch into 3 to increase visibility of the changes.
> 
> Sharlatan Hellseher (3):
>   gnu: packages music: Delete use-module duplicates.
>   gnu: packages music: Sort use-module alphabetically.
>   gnu: abjad: Fix build.

Thanks for these thoughtful revisions! They are a big improvement.

I tweaked the commit messages slightly, added a copyright line for you
to music.scm, and pushed as cbba52aaf7ca9b05c3ff86bfda5d3a7969135e6b

By the way, I think the bug tickets got messed up. Here we are, in the
wsjtx ticket :)