mbox series

[bug#62171,0/2] Fix source build of OpenJDK 9 and 10

Message ID 20230313234935.39a40ac0@tangletp
Headers show
Series Fix source build of OpenJDK 9 and 10 | expand

Message

Björn Höfling March 13, 2023, 10:49 p.m. UTC 
This fixes  62071.

Björn Höfling (2):
  gnu: openjdk9: Build from hg.
  gnu: openjdk10: Build from hg.

 gnu/packages/java.scm | 41 +++++++++++++++++++----------------------
 1 file changed, 19 insertions(+), 22 deletions(-)


base-commit: 5312d798ac36a72d8a977325a7c6ff7647be670a

Comments

Julien Lepiller March 14, 2023, 7:02 a.m. UTC | #1 
Both LGTM. The snippet doesn't need to end with #t anymore. Also not sure if it's my mail client or the patch, but there's a newline missing at the end of the snippets, before sha256.

Le 13 mars 2023 23:49:35 GMT+01:00, "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de> a écrit :
>This fixes  62071.
>
>Björn Höfling (2):
>  gnu: openjdk9: Build from hg.
>  gnu: openjdk10: Build from hg.
>
> gnu/packages/java.scm | 41 +++++++++++++++++++----------------------
> 1 file changed, 19 insertions(+), 22 deletions(-)
>
>
>base-commit: 5312d798ac36a72d8a977325a7c6ff7647be670a
Björn Höfling March 16, 2023, 9:10 a.m. UTC | #2 
On Tue, 14 Mar 2023 08:02:26 +0100
Julien Lepiller <julien@lepiller.eu> wrote:

> Both LGTM. The snippet doesn't need to end with #t anymore. Also not
> sure if it's my mail client or the patch, but there's a newline
> missing at the end of the snippets, before sha256.

Good hint: That newline was left out only in the email. I need to
re-check my client's configuration next time.

Thanks for the review,

with your changes pushed as

7636c49b45adb9870cf416c64bde032ec858a820

Björn