mbox series

[bug#61423,0/6] gnu: zrythm: Update to 1.0.0-beta.4.5.62

Message ID 20230211103537.24139-1-maya.tomasek@disroot.org
Headers show
Series gnu: zrythm: Update to 1.0.0-beta.4.5.62 | expand

Message

Maya Tomasek Feb. 11, 2023, 10:35 a.m. UTC
I have updated 60232 to the latest version of Zrythm. The app launches successfully
and plays audio through JACK (through pw-jack zrythm_launch). I have not managed to
reproduce Sugosha's issues with locale-gen, as I don't have non-english locale. But
I tried to compile Zrythm with -Dalsa=enabled, which didn't make Alsa available as
a backend.

Antero Mejr (5):
  gnu: zrythm: Update to 1.0.0-beta.4.5.1.
  gnu: Add libpanel.
  gnu: Add zix.
  gnu: carla: Update to 2.6.0 pre-release.
  gnu: libaudec: Update to 0.3.4.

Maya Tomasek (1):
  gnu: zrythm: Update to 1.0.0-beta.4.5.62.

 gnu/packages/audio.scm          |  14 ++--
 gnu/packages/datastructures.scm |  40 +++++++++++
 gnu/packages/gtk.scm            |  35 ++++++++++
 gnu/packages/music.scm          | 114 +++++++++++++++++++++-----------
 4 files changed, 157 insertions(+), 46 deletions(-)

Comments

Alexandros Theodotou Feb. 24, 2023, 11:11 p.m. UTC | #1
Hi,

Thanks for working on this. I'm the Zrythm author and was also the
person who first packaged this but I don't use Guix anymore. Feel free
to ask if you need help related to building/running.

From a packager's standpoint I think the unreleased Carla package
should probably be separate from stable Carla.

> I tried to compile Zrythm with -Dalsa=enabled, which didn't make Alsa
> available as a backend.

The pure Alsa backend is broken so I disabled it. You can enable the
rtaudio dependency for ALSA/pulseaudio support (it acts as a wrapper).

Thanks,
Alex
Ludovic Courtès Feb. 27, 2023, 2:44 p.m. UTC | #2
Hi Maya,

Could you look into the suggestions Alexandros made (I agree regarding
Carla) and send a v2 of the patch series?

It looks almost ready to apply!

Thanks,
Ludo’.

Alexandros Theodotou <alex@zrythm.org> skribis:

> Hi,
>
> Thanks for working on this. I'm the Zrythm author and was also the
> person who first packaged this but I don't use Guix anymore. Feel free
> to ask if you need help related to building/running.
>
>>From a packager's standpoint I think the unreleased Carla package
> should probably be separate from stable Carla.
>
>> I tried to compile Zrythm with -Dalsa=enabled, which didn't make Alsa
>> available as a backend.
>
> The pure Alsa backend is broken so I disabled it. You can enable the
> rtaudio dependency for ALSA/pulseaudio support (it acts as a wrapper).
>
> Thanks,
> Alex
ashish.is--- via Guix-patches" via Feb. 28, 2023, 6:38 p.m. UTC | #3
Ludovic Courtès <ludo@gnu.org> writes:

Hi Ludo',

> Hi Maya,
>
> Could you look into the suggestions Alexandros made (I agree regarding
> Carla) and send a v2 of the patch series?

Certainly! Should I open it as another patch? I am not certain how these
things work.

From Antero Mejr (the previous person to update the package):
> (module-ref (resolve-interface ... 'libbacktrace)
> was a quick workaround to avoid an cyclical import. It's not ideal and
> I'm not sure if the maintainers would find it to be acceptable.

Is that line fine? Or should I find some other fix?

Regards
Maya
Ludovic Courtès March 3, 2023, 10:54 a.m. UTC | #4
Hi Mája,

Mája Tomášek <maya.tomasek@disroot.org> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
> Hi Ludo',
>
>> Hi Maya,
>>
>> Could you look into the suggestions Alexandros made (I agree regarding
>> Carla) and send a v2 of the patch series?
>
> Certainly! Should I open it as another patch? I am not certain how these
> things work.

You don’t need to open a new bug.

Instead, create the messages with:

  git format-patch --subject-prefix="PATCH v2" …

and send them all to 61423@debbugs.gnu.org.

> From Antero Mejr (the previous person to update the package):
>> (module-ref (resolve-interface ... 'libbacktrace)
>> was a quick workaround to avoid an cyclical import. It's not ideal and
>> I'm not sure if the maintainers would find it to be acceptable.
>
> Is that line fine? Or should I find some other fix?

No it’s not fine, it should be treated like other packages.

If that causes problem, then we’ll see, but it shouldn’t.

Thanks,
Ludo’.