mbox series

[bug#59487,v3,0/6] guix: dune-build-system: Run all tests.

Message ID 20230113105440.28258-1-pukkamustard@posteo.net
Headers show
Series guix: dune-build-system: Run all tests. | expand

Message

pukkamustard Jan. 13, 2023, 10:54 a.m. UTC 
This removes the usage of the `test-target` argument from dune-build-system
completely. Dune automatically finds tests for packages being built. The
previous test-target was limiting the search of tests to specific folders. In
some cases the wrong folders.

I could not systematically check all affected packages, but have fixed tests
for some (these are packages for which previously we were not running tests).

-pukkamustard

pukkamustard (5):
  gnu: Add ocaml-cinaps.
  gnu: ocaml-ppxlib: Clean up inputs.
  gnu: ocaml-cohttp: Run tests.
  guix: dune-build-system: Run all tests.
  gnu: ocaml-ppx-expect: Disable tests.

raingloom (1):
  guix: dune-build-system: Remove usage of test-target argument.

 gnu/packages/ocaml.scm           | 209 +++++++++++++------------------
 guix/build/dune-build-system.scm |   4 +-
 2 files changed, 86 insertions(+), 127 deletions(-)


base-commit: 9ad5c3deeaebfb6f953579992a082d8327730611

Comments

Julien Lepiller Jan. 15, 2023, 3:02 p.m. UTC | #1 
I was able to check the dependents, so pushed to master as
7686b68f6bb1ae5dc206178805c32bceceea3743 -
79bf3b54a64e304a29334b5029c24d942d9dc051.

Note that I moved patches around, to have the last one before removing
test-target. I merged patches 3, 4 and 5 because intermediate states
would have failing packages otherwise. Also, patch 5 had unrelated
changes to lablgtk3 which I droped, because the package still builds.
If that was intentional, please send a new patch for that :)

I also listed all modified packages in the commit message, and removed
the Co-authored line which listed the author already.

Thanks!