From patchwork Tue Dec 27 21:23:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 1159 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 07C3D27BBE9; Tue, 27 Dec 2022 21:25:36 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 1FFA527BBEB for ; Tue, 27 Dec 2022 21:25:33 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pAHRk-0000of-6o; Tue, 27 Dec 2022 16:25:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAHRi-0000oR-OL for guix-patches@gnu.org; Tue, 27 Dec 2022 16:25:14 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pAHRX-0003LH-4v for guix-patches@gnu.org; Tue, 27 Dec 2022 16:25:14 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pAHRW-0007p5-P0 for guix-patches@gnu.org; Tue, 27 Dec 2022 16:25:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60365] [PATCH 0/4] Rationalize 'PS1' handling in home, system, and shell Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 27 Dec 2022 21:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 60365 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 60365@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167217624329981 (code B ref -1); Tue, 27 Dec 2022 21:25:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Dec 2022 21:24:03 +0000 Received: from localhost ([127.0.0.1]:56586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAHQZ-0007nU-Bo for submit@debbugs.gnu.org; Tue, 27 Dec 2022 16:24:03 -0500 Received: from lists.gnu.org ([209.51.188.17]:46492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAHQY-0007nA-1D for submit@debbugs.gnu.org; Tue, 27 Dec 2022 16:24:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAHQX-0000kQ-Qe for guix-patches@gnu.org; Tue, 27 Dec 2022 16:24:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAHQX-0003D1-AM; Tue, 27 Dec 2022 16:24:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=sZwX1fJ+dcPpPRPn6A81TuwIlDXxI8I6IXofP1f55ZI=; b=iay6vTRpEsYy/8 nWIgVfiHh0MY/REwFRIr0qnom1iyDVol3j+LEEfJrIolE2N+B2h4Lx1cKfB5oDs9OohNZyIy/3hva 7adGfEuj6oGSEBm8jEjmt7JRnsAPjLwu8D+1YzjFgONk1hCMD96t5gJArKa6NipxcZUNfUcyXrk6i CyqCrnmngzBAh2QC9Vatyy+3K2MkP91AmYf2T0PXSBsZakqiQjSCImxkU8XiFcEYguojpJ0BKA4HK C5FeMeaK+fLzG3y4aPDf6JPTJZp1Lu9kNuJ6ZGqUxWRD+mnCuveQqscXNlZM3puor6hx7LDyJgbt8 zpBx/XSY8IGnwX7JiBxA==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pAHQW-0006gW-U0; Tue, 27 Dec 2022 16:24:01 -0500 From: Ludovic =?utf-8?q?Court=C3=A8s?= Date: Tue, 27 Dec 2022 22:23:42 +0100 Message-Id: <20221227212342.17939-1-ludo@gnu.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hello! I found some things could be improved in how we deal with ‘PS1’ in Guix Home, Guix System, and ‘guix shell’ (my initial motivation was making it easy to change ‘PS1’ from a Home configuration). These patches fiddle with ‘PS1’. The most visible effect is that Guix Home’s ~/.bashrc will no longer provide a default ‘PS1’. Thoughts? Ludo’. Ludovic Courtès (4): system, home: Factorize default '.bashrc'. system: Define default 'PS1' in /etc/bashrc rather than ~/.bashrc. environment: Simplify 'PS1' suggestion on '--check'. environment: Avoid false positive on 'PS1' check. gnu/home/services/shells.scm | 41 +++--------------------------------- gnu/system.scm | 3 +++ gnu/system/shadow.scm | 33 +++++++++++++---------------- guix/scripts/environment.scm | 12 ++++++----- 4 files changed, 28 insertions(+), 61 deletions(-) base-commit: 9369c1ccf47d9bf6f2e28a9454c1c329a2044f19 prerequisite-patch-id: aae3af39aa7753dd7ed6d0584587a06d51402386