mbox series

[bug#58433,0/2] Accept tags in the 'commit' field of <channel>

Message ID 20221011095117.31182-1-ludo@gnu.org
Headers show
Series Accept tags in the 'commit' field of <channel> | expand

Message

Ludovic Courtès Oct. 11, 2022, 9:51 a.m. UTC 
Hi!

This change lets us pass tags to ‘guix time-machine’ and ‘guix pull’,
as in:

  guix time-machine --commit=v1.2.0 -- describe

At last!

Thoughts?

Ludo’.

Ludovic Courtès (2):
  git: 'update-cached-checkout' returns the commit ID when given a tag.
  channels: Interpret the 'commit' field of channel as a tag or commit.

 doc/guix.texi     | 23 +++++++++++++++++++++--
 guix/channels.scm |  2 +-
 guix/git.scm      | 15 +++++++++------
 guix/inferior.scm |  2 +-
 tests/git.scm     | 32 +++++++++++++++++++++++++++++++-
 5 files changed, 63 insertions(+), 11 deletions(-)


base-commit: 5d5bc072059f514394afdaccfcc72cdb282d7ce2

Comments

Christopher Baines Oct. 13, 2022, 1:03 p.m. UTC | #1 
Ludovic Courtès <ludo@gnu.org> writes:

> This change lets us pass tags to ‘guix time-machine’ and ‘guix pull’,
> as in:
>
>   guix time-machine --commit=v1.2.0 -- describe
>
> At last!
>
> Thoughts?

This sounds good to me :)

Thanks,

Chris
Ludovic Courtès Oct. 17, 2022, 8:47 a.m. UTC | #2 
Hi,

Christopher Baines <mail@cbaines.net> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> This change lets us pass tags to ‘guix time-machine’ and ‘guix pull’,
>> as in:
>>
>>   guix time-machine --commit=v1.2.0 -- describe
>>
>> At last!
>>
>> Thoughts?
>
> This sounds good to me :)

Pushed, thanks for taking a look!

  f36522416e * channels: Interpret the 'commit' field of channel as a tag or commit.
  46f7011591 * git: 'update-cached-checkout' returns the commit ID when given a tag.

Ludo’.