mbox series

[bug#57721,0/4] gnu: base: Add greetd-wlgreet-sway-session.

Message ID 20220910202903.17482-1-paren@disroot.org
Headers show
Series gnu: base: Add greetd-wlgreet-sway-session. | expand

Message

\( Sept. 10, 2022, 8:29 p.m. UTC
Hey Guix!

This patchset adds support for a second greetd greeter: wlgreet. This
is my first time contributing additions to the documentation, so I
probably got something wrong there; corrections would be appreciated!

( (4):
  gnu: Add rust-greetd-ipc-0.8.
  gnu: Add rust-os-pipe-0.8.
  gnu: Add wlgreet.
  gnu: base: Add greetd-wlgreet-sway-session.

 doc/guix.texi              |  76 +++++++++++++++++++++++
 gnu/packages/admin.scm     |  71 +++++++++++++++++++++
 gnu/packages/crates-io.scm |  46 +++++++++++++-
 gnu/services/base.scm      | 122 +++++++++++++++++++++++++++++++++++++
 4 files changed, 314 insertions(+), 1 deletion(-)

Comments

Christopher Baines Oct. 6, 2022, 2:13 p.m. UTC | #1
"( via Guix-patches" via <guix-patches@gnu.org> writes:

> This patchset adds support for a second greetd greeter: wlgreet. This
> is my first time contributing additions to the documentation, so I
> probably got something wrong there; corrections would be appreciated!
>
> ( (4):
>   gnu: Add rust-greetd-ipc-0.8.
>   gnu: Add rust-os-pipe-0.8.
>   gnu: Add wlgreet.
>   gnu: base: Add greetd-wlgreet-sway-session.
>
>  doc/guix.texi              |  76 +++++++++++++++++++++++
>  gnu/packages/admin.scm     |  71 +++++++++++++++++++++
>  gnu/packages/crates-io.scm |  46 +++++++++++++-
>  gnu/services/base.scm      | 122 +++++++++++++++++++++++++++++++++++++
>  4 files changed, 314 insertions(+), 1 deletion(-)

Sorry for the delay in looking at this, I've gone ahead and pushed the
new packages now.

As for the service, it would be good to have a system test doing
something with it, I don't know how feasible it is?

I'm happy to merge it though if it works. I haven't tested it, but if
someone could that would be useful. If that doesn't happen though, I'm
happy to merge it anyway.

If you could send the remaining patch again (to the same issue), that
would be useful too.

Thanks,

Chris
\( Oct. 6, 2022, 6:21 p.m. UTC | #2
Hi Christopher,

On Thu Oct 6, 2022 at 3:13 PM BST, Christopher Baines wrote:
> Sorry for the delay in looking at this, I've gone ahead and pushed the
> new packages now.

Thanks! :D

> As for the service, it would be good to have a system test doing
> something with it, I don't know how feasible it is?

I have no idea either, but I suspect it's not feasible, since greetd
itself doesn't have any system tests.

> I'm happy to merge it though if it works. I haven't tested it, but if
> someone could that would be useful. If that doesn't happen though, I'm
> happy to merge it anyway.

It works, I've tested it and have been using it for a while.

> If you could send the remaining patch again (to the same issue), that
> would be useful too.

Okay, I've rebased it on the latest master and will send it independently.

    -- (
Christopher Baines Oct. 11, 2022, 11:08 a.m. UTC | #3
"(" <paren@disroot.org> writes:

>> If you could send the remaining patch again (to the same issue), that
>> would be useful too.
>
> Okay, I've rebased it on the latest master and will send it independently.

Thanks, I've pushed this to master now as
59911ae29442aba18bcb53233e793d8f3d264504.

Chris