From patchwork Sat Aug 13 06:50:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Cournoyer X-Patchwork-Id: 896 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id AE77327BBEA; Sat, 13 Aug 2022 07:51:21 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 353B527BBE9 for ; Sat, 13 Aug 2022 07:51:21 +0100 (BST) Received: from localhost ([::1]:40424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oMkzQ-0002tF-9s for patchwork@mira.cbaines.net; Sat, 13 Aug 2022 02:51:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oMkz8-0002rp-4S for guix-patches@gnu.org; Sat, 13 Aug 2022 02:51:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41500) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oMkz7-0005qQ-SE for guix-patches@gnu.org; Sat, 13 Aug 2022 02:51:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oMkz7-0006gy-Md for guix-patches@gnu.org; Sat, 13 Aug 2022 02:51:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57168] [PATCH 00/14] Add a LightDM service. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 13 Aug 2022 06:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 57168 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 57168@debbugs.gnu.org Cc: Maxim Cournoyer X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166037342525663 (code B ref -1); Sat, 13 Aug 2022 06:51:01 +0000 Received: (at submit) by debbugs.gnu.org; 13 Aug 2022 06:50:25 +0000 Received: from localhost ([127.0.0.1]:59482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMkyX-0006fq-8i for submit@debbugs.gnu.org; Sat, 13 Aug 2022 02:50:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:55590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMkyS-0006fZ-PW for submit@debbugs.gnu.org; Sat, 13 Aug 2022 02:50:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44686) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oMkyS-0002XE-Ey for guix-patches@gnu.org; Sat, 13 Aug 2022 02:50:20 -0400 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]:41656) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oMkyQ-0005cJ-7i for guix-patches@gnu.org; Sat, 13 Aug 2022 02:50:19 -0400 Received: by mail-qt1-x835.google.com with SMTP id c20so2280447qtw.8 for ; Fri, 12 Aug 2022 23:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=xpATqBABZkOMVnchpKHdzOXzWB53iR9IKvNviDdQCys=; b=qRisU7BQvhnou+RHrkLPIUuTHvmBPJ89KvraZ3mch/uaxMCPSH32ByyK9R5u4ekzv/ yBk0Pld1yzfKlr9mmJLhY2L2gz5OvklDdLc9wEA6F6yT87MHHd7gWi7+eQU4Xxxh35Id TjtkowxvWy51C2EE5uTeYV1T75Fl7m+7f+k5neBrKWR02Nh6ey+PTFwD7VZD+OJnJb0u jUpZ4WLoQrel+wb6KNwEoscVz9KsdNm8NrnUMJSpykCt3uCHiHvwtf/Uxh9EdVNrpit2 f0cJuCkhjRtn4Y2NXiSE8J2t8tHcAdHgMeu27Qp21mrcSf4/WMUqzz/3bGIyaPQIeVLQ 3KpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=xpATqBABZkOMVnchpKHdzOXzWB53iR9IKvNviDdQCys=; b=N1JAKgIYktR4QNOid0ZDANkmm4XEQnX/FfLM0k4yZF8f837eYnZJH2HFQi4vxtvdHR WkV0SA35tjcTMt5kR8dZeUEypBM1AGN2w7cb+4OfcgbHZ//XyKk7QHMc2xzELR6OqxLm NmxQvJob9neAdVhE5QsOoGWJ2+qPlewKdKkHx9GWeN7ifdRPkvOYMz7Jb5wAGcbAYX9N Xdo3wXw/d2NPUmoKg1Jk3ztb2hN0rvWb1ymj4w45Kc/78AaSTNWF7Kmg9CCksZ5g1NSi 2YZp6cyJqae5PKFGoA1qjwaXLxc9prDya9eHzk0KUO1HTY8n8MkFFm0Z31S66xCk3b4Y NYcA== X-Gm-Message-State: ACgBeo1mCT7e8cg3h/bR24vcxbSJA2pJgNvK3LLQc/04dbdU0I6vYBY/ i3RCz+2zOQFPSf03GGBUCWW4iGNpv7A= X-Google-Smtp-Source: AA6agR4hESJNN9o5bEn3ObhYVYjqj2nBT0FKpyd1nEUbl/+VbBpK2ZcbxUyGrE28fKvC9ghdKINUhw== X-Received: by 2002:a05:622a:1ba5:b0:31f:55c:f033 with SMTP id bp37-20020a05622a1ba500b0031f055cf033mr6548136qtb.300.1660373416514; Fri, 12 Aug 2022 23:50:16 -0700 (PDT) Received: from localhost.localdomain (dsl-205-233-125-72.b2b2c.ca. [205.233.125.72]) by smtp.gmail.com with ESMTPSA id y6-20020ae9f406000000b006b8cff25187sm3544186qkl.42.2022.08.12.23.50.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Aug 2022 23:50:16 -0700 (PDT) From: Maxim Cournoyer Date: Sat, 13 Aug 2022 02:50:06 -0400 Message-Id: <20220813065006.27151-1-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::835; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x835.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hello Guix! This adds a lightdm-service-type, which is based on the work of 'L p R n d n' more than two years ago. It reworks the way configurations are define (via define-configuration), exposes VNC and XDMCP configuration options and adds unit and system tests. It works fine, but there are a few gotchas: 1. The session selection menu doesn't show the items. I don't know why. Perhaps a regresssion with newer GTK+. 2. Because of 1., you should specify a default session, otherwise you won't be able to log in, as the default session is 'default.desktop', which doesn't exist. Thanks, Maxim Cournoyer (14): services: configuration: Add a 'maybe-value-set?' procedure. gnu: accountsservice: Update to 22.08.8, enable doc and test suite. gnu: accountsservice: Provide a means to locate extensions. gnu: lightdm-gtk-greeter: Add GDK_PIXBUF_MODULE_FILE to wrapper. gnu: lightdm-gtk-greeter: Use the glib-or-gtk-wrap phase as-is. gnu: lightdm-gtk-greeter: Enable libklavier support. gnu: lightdm-gtk-greeter: Adjust default config file path. gnu: lightdm-gtk-greeter: Adjust --enable-at-spi-command value. gnu: lightdm: Apply patch to fix a problem with VNC integration. gnu: lightdm: Apply patch to allow using VNC options. gnu: lightdm: Apply patch to fix color depth issue with VNC. marionette: Improve the error message of 'wait-for-screen-text'. build: marionette: Add support for Tesseract OCR. services: Add lightdm-service-type. Makefile.am | 1 + doc/guix.texi | 209 +++++- gnu/build/marionette.scm | 79 +- gnu/local.mk | 5 + gnu/packages/display-managers.scm | 83 ++- gnu/packages/freedesktop.scm | 93 ++- .../patches/accountsservice-extensions.patch | 25 + .../patches/lightdm-arguments-ordering.patch | 54 ++ .../patches/lightdm-vnc-color-depth.patch | 81 +++ .../patches/lightdm-vncserver-check.patch | 66 ++ gnu/services/configuration.scm | 5 + gnu/services/lightdm.scm | 687 ++++++++++++++++++ gnu/tests/base.scm | 4 +- gnu/tests/install.scm | 8 +- gnu/tests/lightdm.scm | 161 ++++ tests/services/lightdm.scm | 52 ++ 16 files changed, 1508 insertions(+), 105 deletions(-) create mode 100644 gnu/packages/patches/accountsservice-extensions.patch create mode 100644 gnu/packages/patches/lightdm-arguments-ordering.patch create mode 100644 gnu/packages/patches/lightdm-vnc-color-depth.patch create mode 100644 gnu/packages/patches/lightdm-vncserver-check.patch create mode 100644 gnu/services/lightdm.scm create mode 100644 gnu/tests/lightdm.scm create mode 100644 tests/services/lightdm.scm