mbox series

[bug#55436,0/3] Update public-inbox to 1.8.0

Message ID 20220515215420.503806-1-bauermann@kolabnow.com
Headers show
Series Update public-inbox to 1.8.0 | expand

Message

Thiago Jung Bauermann May 15, 2022, 9:54 p.m. UTC 
Hello,

These patches fix a few issues with the current public-inbox package, add a
new package which is needed by version 1.8.0, and finally updates
public-inbox.

A few notes regarding the new package perl-socket-msghdr:

- It's based on the package generated by the CPAN importer. As such, the
  origin URL is on CPAN. There's an upstream repo on GitHub¹, but it
  appears inactive. The contents there are identical to the CPAN tarball,
  modulo the files META.json, META.yml and MANIFEST (the former two exist
  only on CPAN, and the latter is changed to include them) so I left the
  origin unchanged.

- There's a file called ‘ppport.h’ with 7k lines that was automatically
  generated by some tool called “Devel::PPPort”. Ideally we should delete
  it and regenerate it, but I haven't done that.

And regarding public-inbox 1.8.0:

- The diff from current version 1.6.1 has about 57k lines (including
  context). I didn't do even a cursory review of the changes.

- The new tool ‘lei’ depends on curl to work. I tried substituting its path
  directly in the source code, but for some reason that didn't work.
  Therefore I settled for adding curl to the PATH with ‘program-wrapper’.

- The tests are disabled because more changes are needed to enable them.
  I have them working in a local branch, but there's one patch to the
  public-inbox testsuite which I still need to cleanup and post upstream.
  If anyone is curious about it, I pushed the branch ‘public-inbox-updates’
  to my GitLab repo².

Thiago Jung Bauermann (3):
  gnu: public-inbox: Some packaging fixes
  gnu: Add perl-socket-msghdr
  gnu: public-inbox: Update to version 1.8.0

 gnu/packages/mail.scm | 38 +++++++++++++++++++++-----------------
 gnu/packages/perl.scm | 24 ++++++++++++++++++++++++
 2 files changed, 45 insertions(+), 17 deletions(-)

base-commit: 527952945c59f69665e40b6b416141554084e057

Comments

Kyle Meyer May 16, 2022, 2:10 a.m. UTC | #1 
Thiago Jung Bauermann via Guix-patches via writes:

> Hello,
>
> These patches fix a few issues with the current public-inbox package, add a
> new package which is needed by version 1.8.0, and finally updates
> public-inbox.

Thanks for working on this.

> [...]
> - The tests are disabled because more changes are needed to enable them.
>   I have them working in a local branch, but there's one patch to the
>   public-inbox testsuite which I still need to cleanup and post upstream.
>   If anyone is curious about it, I pushed the branch ‘public-inbox-updates’
>   to my GitLab repo².

Fwiw I applied your patches and tested it a bit with my local inboxes.
I didn't spot any issues.

--8<---------------cut here---------------start------------->8---

[guix env]% realpath $(which lei)
/gnu/store/564p55ajr8wlbml1rafs4pggjzpvmqaf-public-inbox-1.8.0/bin/lei

[guix env]% lei daemon-pid
199095

[guix env]% lei q -f ldjson -O guix-patches nq:lei d:30.days.ago.. | jq '.s' | sort | uniq
"[bug#54997] [PATCH 04/12] Add (guix least-authority)."
"[bug#55436] [PATCH 0/3] Update public-inbox to 1.8.0"
"[bug#55436] [PATCH 3/3] gnu: public-inbox: Update to version 1.8.0"

[guix env]% lei daemon-kill
[guix env]% lei daemon-pid
199200

[guix env]% lei q -O https://lore.kernel.org/git -o mboxcl2:/tmp/t.mbox nq:pack d:20.days.ago..
# /gnu/store/i11i4xrx3gibdm012bqqhgrjs69qyia3-curl-7.79.1/bin/curl -Sf -s -d '' https://lore.kernel.org/git/?x=m&q=nq%3Apack+dt%3A20220426015402..
# https://lore.kernel.org/git/ 57/57
# 57 written to /tmp/t.mbox (57 matches)

[guix env]% public-inbox-httpd &
[1] 199585
# browsed around http://127.0.0.1:8080/guix-patches/ a bit
--8<---------------cut here---------------end--------------->8---
Thiago Jung Bauermann May 16, 2022, 2:31 a.m. UTC | #2 
Kyle Meyer <kyle@kyleam.com> writes:

> Thiago Jung Bauermann via Guix-patches via writes:
>
>> Hello,
>>
>> These patches fix a few issues with the current public-inbox package, add a
>> new package which is needed by version 1.8.0, and finally updates
>> public-inbox.
>
> Thanks for working on this.

No problem. Sorry to take so long. There were a surprising number of
little issues along the way…

>> [...]
>> - The tests are disabled because more changes are needed to enable them.
>>   I have them working in a local branch, but there's one patch to the
>>   public-inbox testsuite which I still need to cleanup and post upstream.
>>   If anyone is curious about it, I pushed the branch ‘public-inbox-updates’
>>   to my GitLab repo².
>
> Fwiw I applied your patches and tested it a bit with my local inboxes.
> I didn't spot any issues.

<snip>

Awesome! Thank you for testing. You certainly use a lot more features of
the package than I do.