mbox series

[bug#55404,0/2] Make 'description' of <service-type> mandatory

Message ID 20220513214318.27355-1-ludo@gnu.org
Headers show
Series Make 'description' of <service-type> mandatory | expand

Message

Ludovic Courtès May 13, 2022, 9:43 p.m. UTC 
Hi!

This change makes the ‘description’ field of <service-type> mandatory.
I think it’s necessary if we are to make ‘guix system search’, ‘guix
home search’, and similar tools useful.

Objections?

Thanks,
Ludo’.

Ludovic Courtès (2):
  services: Add more description fields.
  services: Make <service-type> 'description' field mandatory.

 gnu/services.scm       | 6 +++---
 gnu/services/base.scm  | 3 ++-
 gnu/system/install.scm | 6 ++++--
 gnu/tests.scm          | 7 +++++--
 4 files changed, 14 insertions(+), 8 deletions(-)


base-commit: 2e6f4220cffc72f55f5390a57499e95fc9a03796

Comments

Maxim Cournoyer May 18, 2022, 4:43 a.m. UTC | #1 
Hello Ludovic,

Ludovic Courtès <ludo@gnu.org> writes:

> Hi!
>
> This change makes the ‘description’ field of <service-type> mandatory.
> I think it’s necessary if we are to make ‘guix system search’, ‘guix
> home search’, and similar tools useful.
>
> Objections?

None.  Go for it!

(LGTM)

Maxim
Ludovic Courtès May 18, 2022, 8:37 p.m. UTC | #2 
Hello,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hi!
>>
>> This change makes the ‘description’ field of <service-type> mandatory.
>> I think it’s necessary if we are to make ‘guix system search’, ‘guix
>> home search’, and similar tools useful.
>>
>> Objections?
>
> None.  Go for it!

Alright, pushed as 3948ac25b1dccc40c7fdf56377f94a0775a835ee with
additional ‘tests/services.scm’ changes I had forgotten.

Thanks for taking a look!

Ludo’.