From patchwork Fri Apr 1 20:44:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Boulain X-Patchwork-Id: 692 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 8F7EB27BBEA; Fri, 1 Apr 2022 21:43:25 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,PDS_BTC_ID, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id EBF1327BBE9 for ; Fri, 1 Apr 2022 21:43:24 +0100 (BST) Received: from localhost ([::1]:50070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1naO78-0002ps-I6 for patchwork@mira.cbaines.net; Fri, 01 Apr 2022 16:43:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naO6p-0002pG-PK for guix-patches@gnu.org; Fri, 01 Apr 2022 16:43:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49787) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1naO6n-0005v6-LU for guix-patches@gnu.org; Fri, 01 Apr 2022 16:43:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1naO6n-0007u3-JR for guix-patches@gnu.org; Fri, 01 Apr 2022 16:43:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54379] [PATCH 0/3] gnu: linux: update PipeWire & WirePlumber References: <20220313223533.9632-1-kevinboulain@gmail.com> In-Reply-To: <20220313223533.9632-1-kevinboulain@gmail.com> Resent-From: Kevin Boulain Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 01 Apr 2022 20:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54379 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 54379@debbugs.gnu.org Cc: Kevin Boulain , Maxime Devos Received: via spool by 54379-submit@debbugs.gnu.org id=B54379.164884577130324 (code B ref 54379); Fri, 01 Apr 2022 20:43:01 +0000 Received: (at 54379) by debbugs.gnu.org; 1 Apr 2022 20:42:51 +0000 Received: from localhost ([127.0.0.1]:43675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1naO6c-0007t0-Nk for submit@debbugs.gnu.org; Fri, 01 Apr 2022 16:42:51 -0400 Received: from mail-ej1-f49.google.com ([209.85.218.49]:34496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1naO6a-0007sn-Tr for 54379@debbugs.gnu.org; Fri, 01 Apr 2022 16:42:49 -0400 Received: by mail-ej1-f49.google.com with SMTP id o10so8303549ejd.1 for <54379@debbugs.gnu.org>; Fri, 01 Apr 2022 13:42:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+zwDjU/ooAYyNgYU9OpDKMBsP+8xaubzSzEe6gVSJbM=; b=KOU4c7yUZI9tbLCfpRRE2UntfO665zjLMokqJlC8yDesuBZ5sKuFl3EIedRSpiNuwM /goV5Sju4Wi15wA0nBWVvvYjz4c6LHOSJ8Cl2wvyoMtIxE9ef6xz/Azmq9whpooXEoDw //CY5mw12y4pnE3LFXyHv6NYfq0W0u+/D6xe7LHeOunJOLYDqXI5kuuTYtg72HCEsIti SlkV3XZ4TOZlv9CfEoFFCCruAJSgtd+gyq9tJ3YUnIGyer3kWLBHX8eFmZv1PhxR+khk r3ng11LLWNXbHylLPgUWFhCGmgFxt4TmWBXhJbVl8VNp9gUKS0Ma2TkK/OywPWykKQhS EiHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+zwDjU/ooAYyNgYU9OpDKMBsP+8xaubzSzEe6gVSJbM=; b=dTD6+XnLY1x3ZclLz9o7jEovOUV5+LoxzjiUaZP2QB0DGGubkHbPEBDrhDImu9m1Hv o0ywIsDFoMYiSLFlsiCOWQlc1cCU1B1HcprlCaa/DhRfqOxkzHBqyVZqbdj8TlRDgkBa zCw/iPmWd50FU6ri0pva7drbj6zUJuNaxB685UVbTDNcaZ5S9AR5FiMDLjmCjFINr7g0 soYCnSsIbe8ulUsXUZYrVa35WSXPccivrEg1Cmz6bqEeFm7ikNbtuLlNPoZz8Mh0FtBj e1SuQLW55WtipUC48lqCU7rObojO6QpFrs805suQLDZfj2yHSjhVljKagNI4y+KnJEhi Laxg== X-Gm-Message-State: AOAM5326UWYgJXLxMYW9aGZd/X77atThn63XEh+MZDGrIHLziF96nb8F NX69r/SRJmF4NYCkbIorQarNtF2XAXc= X-Google-Smtp-Source: ABdhPJzNCsfI3/lNbt28vHZoF5GU0Evf9KmETQBU8mxx9QUlfKPQUG+awJYLKghVlreOEJhTpwvpwA== X-Received: by 2002:a17:906:5006:b0:6ce:3762:c72e with SMTP id s6-20020a170906500600b006ce3762c72emr1357698ejj.30.1648845762721; Fri, 01 Apr 2022 13:42:42 -0700 (PDT) Received: from localhost.localdomain ([51.154.70.17]) by smtp.gmail.com with ESMTPSA id i22-20020a170906251600b006d6d9081f46sm1371720ejb.150.2022.04.01.13.42.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Apr 2022 13:42:42 -0700 (PDT) From: Kevin Boulain Date: Fri, 1 Apr 2022 22:44:38 +0200 Message-Id: <20220401204441.8244-1-kevinboulain@gmail.com> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches On Fri, 1 Apr 2022 at 21:34, Maxime Devos wrote: > What's the impact on the output closure size? I assume you mean ./pre-inst-env guix size pipewire? store item total self /gnu/store/vbcfrng1aadxa79g7f8mlgm7wp9dzqwf-mesa-21.3.2 411.5 169.5 21.2% /gnu/store/fvfymzksvj8k6pc54gmhx2lnvkxysfd8-llvm-11.0.0 221.5 149.5 18.7% /gnu/store/b6j1qw1a5rkbfvcy7lc9fm95abbzpa4x-python-3.9.9 155.3 63.7 8.0% /gnu/store/cnfsv9ywaacyafkqdqsv2ry8f01yr7a9-guile-3.0.7 129.1 52.0 6.5% /gnu/store/hzic3ddl5yvnyw7gm4a0qc5icgqy2442-icu4c-69.1 110.7 38.0 4.7% /gnu/store/5h2w4qi9hk1qzzgi1w83220ydslinr4s-glibc-2.33 38.3 36.6 4.6% /gnu/store/094bbaq6glba86h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib 71.7 33.4 4.2% /gnu/store/6qlv57cr2xz37sarbwiv6ksqabf589p6-iso-codes-4.5.0 18.5 18.5 2.3% /gnu/store/78b0194wv2d5vrqr408x2m2ndfy11j7j-eudev-3.2.11 102.2 17.7 2.2% /gnu/store/84bvs9y0arsimxd2ay26a57xkqw7nsqm-glib-2.70.2 98.1 15.3 1.9% /gnu/store/rvirnmnxxm2ymqgcxcnj3dxvnrnqlk0l-fftwf-3.3.8 85.9 13.2 1.6% /gnu/store/614385afpnp5kcnixhrz5mz3fnbgyqkf-gst-plugins-base-1.18.5 656.1 12.8 1.6% /gnu/store/df3ghmicrls14q2zcaj86217dicgnzs7-gstreamer-1.18.5 196.6 10.5 1.3% /gnu/store/ln5dqqs2wkhhaqrpib5xqga0m1wpj028-pipewire-0.3.49 799.5 10.2 1.3% /gnu/store/gkjna040y14xvk4y5mcccvjkkmdcvmnv-font-dejavu-2.37 9.8 9.8 1.2% /gnu/store/5583c2za2jsn9g6az79rnksgvigwnsk7-util-linux-2.37.2-lib 80.7 9.0 1.1% /gnu/store/84v5kpb4wcag0q173rq1jc9ajc953455-pulseaudio-15.0 304.1 8.9 1.1% /gnu/store/3dy6pwfayfwdmf9y3rm4yaryzxkbdqv7-libical-3.0.10 149.6 7.5 0.9% /gnu/store/9rrnm5hdjw7cy96a2a9rfgh6y08wsbmf-ncurses-6.2.20210619 77.6 5.9 0.7% /gnu/store/zkl2vfmlifcyxphidx5nbv177qs9ziaz-harfbuzz-2.8.2 147.3 5.5 0.7% /gnu/store/plr00nij45964cyy7sfcg5rcsi8hks0h-openssl-1.1.1l 77.2 5.5 0.7% [...] total: 799.5 MiB Do you need the full output (where should I paste it)? WirePumber doesn't add much: [...] /gnu/store/x4aak1x0l6wvb229zdqh3lh94bf2kl0j-wireplumber-0.4.9 802.3 1.5 0.2% /gnu/store/wa7cjcx12pgx2zpk2psmlpxkmkqn79ri-lua-5.3.5 80.3 1.3 0.2% [...] total: 802.3 MiB > For future reference, I would put this information in comments in the > package definition. That seems much more convenient to me than having > to dig through the git history. I wasn't too sure if that's common style, but I also prefer commenting the dependencies when they aren't obvious. Done. On Fri, 1 Apr 2022 at 21:41, Maxime Devos wrote: > Looks like some of these are only used for some plugins. Yeah, most of them. > Can plugins be built separately? If they are built separately (and > hence, the 'main' pipewire package does not have these extra packages), > then updating, say, lilv, would cause less rebuilds. I've no idea how that works on Guix, I assume it's not as simple as with other distributions where all libraries/plugins can be found in a single place (/lib). Do you have an example? I agree it would be nicer and I'm happy to split the package (talking about plugins, do you happen to have some pointers for https://issues.guix.gnu.org/54379#5?). On Fri, 1 Apr 2022 at 21:42, Maxime Devos wrote: > Can this be updated in a separate patch or are pipewire and wireplumber > too intertwined? It builds and plays sound. I've split the commit. Kevin Boulain (3): gnu: linux: update PipeWire gnu: linux: update WirePlumber gnu: rename pipewire to pipewire-0.2 and pipewire-0.3 to pipewire gnu/packages/chromium.scm | 2 +- gnu/packages/freedesktop.scm | 6 ++-- gnu/packages/gnome.scm | 4 +-- gnu/packages/kde-systemtools.scm | 2 +- gnu/packages/linux.scm | 49 ++++++++++++++++++++------------ gnu/packages/telegram.scm | 2 +- gnu/packages/video.scm | 2 +- 7 files changed, 40 insertions(+), 27 deletions(-)