From patchwork Fri Apr 1 14:59:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 691 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id D493A27BBEA; Fri, 1 Apr 2022 16:01:13 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id A46FD27BBE9 for ; Fri, 1 Apr 2022 16:01:13 +0100 (BST) Received: from localhost ([::1]:38368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1naIm0-0003XM-QW for patchwork@mira.cbaines.net; Fri, 01 Apr 2022 11:01:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44880) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naIlq-0003V2-FZ for guix-patches@gnu.org; Fri, 01 Apr 2022 11:01:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49143) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1naIlq-0005h2-6V for guix-patches@gnu.org; Fri, 01 Apr 2022 11:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1naIlq-0002mv-4Z for guix-patches@gnu.org; Fri, 01 Apr 2022 11:01:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54668] [PATCH 0/3] Turn diagnostic locations into hyperlinks Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 01 Apr 2022 15:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 54668 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 54668@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.164882524210676 (code B ref -1); Fri, 01 Apr 2022 15:01:01 +0000 Received: (at submit) by debbugs.gnu.org; 1 Apr 2022 15:00:42 +0000 Received: from localhost ([127.0.0.1]:43040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1naIlW-0002m8-5w for submit@debbugs.gnu.org; Fri, 01 Apr 2022 11:00:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:54004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1naIlV-0002m1-2u for submit@debbugs.gnu.org; Fri, 01 Apr 2022 11:00:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naIlU-0003P0-1k for guix-patches@gnu.org; Fri, 01 Apr 2022 11:00:40 -0400 Received: from [2001:470:142:3::e] (port=54916 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naIlT-0005f2-FD; Fri, 01 Apr 2022 11:00:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=TofJde+npOFG+ewYV8PEZdqG+OV6+iWJk2YlBOO/kIs=; b=oZzJZE/s+UwPzy cNGlz6H0ePck+w3+tcSGLcHLyg6JqjVO2TkRanlL3JiHzIWz+zxaK5D/mSknNPNF88Eh8lWtq97Dk joQo7mu8RffT6604s9JMZtk0u+/pfQf0SwCBzWMx3uu5z6RNrPHIR5zF0oy2+24vL58/I88QJ9NUo LVva++sYWTe3F6/WHvI4XbBfzvJQOQn0pu+UOtfMru4azMZuiuI6FtCqnC/F14QnlgvuYE4LI8QoY ULTK6dWvVEnpdUHqfWeroRTSIl55BkCIURwPu9o8USeY1T2cYiGcDy4I+OBhDL+962CrZQvgJbYUu CQKuPUHsNW5doqVOMs1A==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=38736 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1naIky-0008WI-LW; Fri, 01 Apr 2022 11:00:37 -0400 From: Ludovic =?utf-8?q?Court=C3=A8s?= Date: Fri, 1 Apr 2022 16:59:55 +0200 Message-Id: <20220401145955.32347-1-ludo@gnu.org> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hello Guix! This patch series shuffles things around and turns diagnostic locations into hyperlinks. That is, on terminals that support it (GNOME Terminal, Terminology, Kitty, etc.¹), every time you see, say: gnu/packages/foo.scm:300:42: warning: something's wrong … the location prefix is now clickable. I did not reexport the bindings moved to (guix diagnostics). To authors of software that uses Guix (GWL in particular), lemme know if that’s a problem! Ludo’. ¹ For some reasons xfce4-terminal no longer supports it; I think it used to. Ludovic Courtès (3): ui: Move hyperlink facilities to (guix colors). ui: Move 'location->hyperlink' to (guix diagnostics). diagnostics: Turn diagnostic locations into hyperlinks. guix/colors.scm | 35 +++++++++++++++++++++++++++++- guix/diagnostics.scm | 16 +++++++++++++- guix/scripts/home.scm | 1 + guix/scripts/system.scm | 1 + guix/scripts/system/search.scm | 4 +++- guix/ui.scm | 39 ---------------------------------- 6 files changed, 54 insertions(+), 42 deletions(-) base-commit: fc94e93c4b60addfda3c1eddfb85907e9459a8af