mbox series

[bug#54471,core-updates,0/2] font-build-system: Install web fonts

Message ID 20220320110043.18099-1-arunisaac@systemreboot.net
Headers show
Series font-build-system: Install web fonts | expand

Message

Arun Isaac March 20, 2022, 11 a.m. UTC 
Hi,

Currently, we don't install the woff and woff2 web fonts in our font build
system. The first patch fixes that. The second patches removes the return of
#t from phases.

Regards,
Arun

Arun Isaac (2):
  build: font-build-system: Install web fonts.
  build: font-build-system: Do not return #t from phases.

 guix/build/font-build-system.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

M March 20, 2022, 11:27 a.m. UTC | #1 
Arun Isaac schreef op zo 20-03-2022 om 16:30 [+0530]:
> Currently, we don't install the woff and woff2 web fonts in our font build
> system. The first patch fixes that. The second patches removes the return of
> #t from phases.

font-build-system currently puts "tar", "gzip", "bzip2", "unzip" (*),
and "xz" in 'host-inputs' (the build system equivalent of 'inputs')
instead of 'build-inputs' (the build system equivalent of 'native-
inputs'), which is wrong when cross-compiling.

For font-build-system, this does not truly matter, since #:target is
ignored for font-build-system.  However, to avoid accidentally teaching
people to accidentally mess up the inputs/native-inputs difference and
instead give the right example, WDYT of moving "tar" and friends to
'build-inputs'?

It's technically a separate thing from your patches, but I think it
would be nice to bundle multiple core-updates changes together (in
separate patches, but in a same ‘push’).

(*) The location of 'source' does not matter since sources are
(currently) assumed to be architecture-independent in Guix.

Greetings,
Maxime.
Arun Isaac March 21, 2022, 12:17 p.m. UTC | #2 
Hi Maxime,

Sure, sounds good! Patches follow in subsequent emails.

Regards,
Arun