From patchwork Sat Dec 18 17:02:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 508 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id B635A27BBEA; Sat, 18 Dec 2021 17:07:06 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 7DB0027BBE9 for ; Sat, 18 Dec 2021 17:07:06 +0000 (GMT) Received: from localhost ([::1]:50648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mydAn-0002jn-Fe for patchwork@mira.cbaines.net; Sat, 18 Dec 2021 12:07:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myd7q-0007sb-Gy for guix-patches@gnu.org; Sat, 18 Dec 2021 12:04:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60385) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myd7q-0007hG-8M for guix-patches@gnu.org; Sat, 18 Dec 2021 12:04:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1myd7q-00050P-5e for guix-patches@gnu.org; Sat, 18 Dec 2021 12:04:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52603] [PATCH 0/2] Flag missing netmasks early on Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 18 Dec 2021 17:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52603 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 52603@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163984698519141 (code B ref -1); Sat, 18 Dec 2021 17:04:01 +0000 Received: (at submit) by debbugs.gnu.org; 18 Dec 2021 17:03:05 +0000 Received: from localhost ([127.0.0.1]:43691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myd6u-0004yf-Mf for submit@debbugs.gnu.org; Sat, 18 Dec 2021 12:03:04 -0500 Received: from lists.gnu.org ([209.51.188.17]:45578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myd6s-0004yX-77 for submit@debbugs.gnu.org; Sat, 18 Dec 2021 12:03:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myd6r-0006gF-Sj for guix-patches@gnu.org; Sat, 18 Dec 2021 12:03:01 -0500 Received: from [2001:470:142:3::e] (port=59050 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myd6T-0007ag-8W; Sat, 18 Dec 2021 12:02:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=ddQqe/BJPC/lenFRW87w8wACN8srkPjrmbqzPz+1o94=; b=lkTeoUbzbqudXS kYsDzPwFNPFiD1Zh3LcXaMcZp+A8tHK74vl3rNngWc+T5fKAnDuIUHcIUddLjw0CRXJfgmhHgcLjQ TO0S3iiEKEfbypXBTYfuhaHtQVY+CS6U6f6QZeFtKZJazaNU2LHArHAhZqHuoLfXd+Mwhcrr4EA4x JLf5rLRTh2dDY2XwXR3JhxZZXxjsuVYHxnRc6EX0KNjQjRm5N0bAAxEbWHGQUovcckUmOTNCvXH8z KDXQ47K2EjiNPIaRc+6z1Qks5g0NOinfzr8UbYJypBUsUo6InlqX4zxKP3um3W8rrI4L3H8UF1m6k HFR3XT+dzQDIrJ3tAHsQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:61383 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myd6T-0007lf-8A; Sat, 18 Dec 2021 12:02:37 -0500 From: Ludovic =?utf-8?q?Court=C3=A8s?= Date: Sat, 18 Dec 2021 18:02:27 +0100 Message-Id: <20211218170227.19999-1-ludo@gnu.org> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi! As discussed yesterday on IRC, I mistakenly configured a machine with something like: (network-address (device "eno1") (value "1.2.3.4")) This results in having a “/0” subnet, thereby preventing the addition of a route without a clear diagnostic from Guile-Netlink or ‘ip’. To avoid this, this patch flags it at expansion time (if possible) or at run time, before the machine configuration is built. Did I go overboard with ‘define-compile-time-procedure’? I don’t think so :-), I think it will serve us more than once. Thoughts? Ludo’. Ludovic Courtès (2): combinators: Add 'define-compile-time-procedure'. services: static-networking: Sanitize values. gnu/services/base.scm | 28 ++++++++++++++++++++++-- guix/combinators.scm | 50 +++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 74 insertions(+), 4 deletions(-) base-commit: 4204156eb4c1afd5365ef505e356f87daa91787d