mbox series

[bug#50117,0/1] go-github-com-aswinkarthik-csvdiff package updates

Message ID 20211210111752.20147-1-me@bonfacemunyoki.com
Headers show
Series go-github-com-aswinkarthik-csvdiff package updates | expand

Message

Munyoki Kilyungi Dec. 10, 2021, 11:17 a.m. UTC 
Hi all!  Find below updated patches from a review from a while back.  @Arun, I
have moved csvdiff to textutils(it makes more semantic sense).  I see no need
of defining it as a deprecated-package since there's no package dependent on
it ATM.  Let me know if I need to change anything.  Thanks for being patient
with this!

BonfaceKilz (1):
  gnu: Move csvdiff to (gnu packages textutils).

 gnu/packages/golang.scm    | 44 ------------------------------------
 gnu/packages/textutils.scm | 46 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+), 44 deletions(-)

Comments

Arun Isaac Dec. 13, 2021, 6:08 a.m. UTC | #1 
Hi Bonface,

> Hi all!  Find below updated patches from a review from a while back.  @Arun, I
> have moved csvdiff to textutils(it makes more semantic sense).

Sounds good.

> I see no need of defining it as a deprecated-package since there's no
> package dependent on it ATM.

Users might have installed csvdiff into their profiles. So, I think we
still need to define a deprecated-package. Could you send an updated
patchset?

Thanks!
Arun
Munyoki Kilyungi Dec. 13, 2021, 6:50 a.m. UTC | #2 
Arun Isaac <arunisaac@systemreboot.net> anaandika:

> Hi Bonface,
>
>> Hi all!  Find below updated patches from a review from a while back.  @Arun, I
>> have moved csvdiff to textutils(it makes more semantic sense).
>
> Sounds good.
>
>> I see no need of defining it as a deprecated-package since there's no
>> package dependent on it ATM.
>
> Users might have installed csvdiff into their profiles. So, I think we
> still need to define a deprecated-package. Could you send an updated
> patchset?
>

Sure.  Let me do that later during the day...

> Thanks!
> Arun