Message ID | 20211116101043.58471-1-zimon.toutoune@gmail.com |
---|---|
Headers | show |
Series | import: opam: Warn instead of leave when fetching fails. | expand |
Le Tue, 16 Nov 2021 11:10:43 +0100, zimoun <zimon.toutoune@gmail.com> a écrit : > Hi, > > It is possible to use another OPAM repository when importing, for > instance "guix import opam --repo=https://coq.inria.fr/opam/released" > -- although Coq packages are generally not built using OCaml or Dune > build-system, another story. :-) Or even, a package using OCaml or > Dune build system but not included in Opam repositories supported by > Guix. > Hi, I already had a patch for that, which is a bit more complex, at https://issues.guix.gnu.org/51091. WDYT?
Hi, On Tue, 16 Nov 2021 at 14:03, Julien Lepiller <julien@lepiller.eu> wrote: > I already had a patch for that, which is a bit more complex, at Sorry, I missed it. > https://issues.guix.gnu.org/51091. WDYT? Your patch LGTM. I am not convinced that all the complexity is worth; compared to the proposed trivial change. ;-) From my opinion, the way is a common error for the all importers and raise it; all the catch happening in 'guix/scripts/'. That's another story. :-) One minor comment, in 'latest-release' I would write "opam: package '~a' not found~%" otherwise the message "guix lint: warning: package 'example' not found" looks odd (at least to me :-)). Feel free to close this issue and the other once you pushed a fix. Cheers, simon
Pushed to master as b5d51bb19e790baee9b16a3325397ec92d8e7625, thanks!
Forgot to close.