From patchwork Mon Nov 15 20:26:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josselin Poiret X-Patchwork-Id: 453 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 275AD27BBE3; Mon, 15 Nov 2021 20:28:11 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id B3D3627BBE3 for ; Mon, 15 Nov 2021 20:28:10 +0000 (GMT) Received: from localhost ([::1]:57674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmiaH-0007fL-Sw for patchwork@mira.cbaines.net; Mon, 15 Nov 2021 15:28:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmiaA-0007ex-FT for guix-patches@gnu.org; Mon, 15 Nov 2021 15:28:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44740) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmiaA-00036q-7d for guix-patches@gnu.org; Mon, 15 Nov 2021 15:28:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mmiaA-0008Vd-3r for guix-patches@gnu.org; Mon, 15 Nov 2021 15:28:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51346] [PATCH v3 0/5] Rework swap device to add dependencies and flags Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 15 Nov 2021 20:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51346 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?utf-8?q?Court=C3=A8s?= Cc: Josselin Poiret , Tobias Geerinckx-Rice , 51346@debbugs.gnu.org Received: via spool by 51346-submit@debbugs.gnu.org id=B51346.163700803732590 (code B ref 51346); Mon, 15 Nov 2021 20:28:02 +0000 Received: (at 51346) by debbugs.gnu.org; 15 Nov 2021 20:27:17 +0000 Received: from localhost ([127.0.0.1]:56268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmiZQ-0008TT-Lq for submit@debbugs.gnu.org; Mon, 15 Nov 2021 15:27:17 -0500 Received: from jpoiret.xyz ([206.189.101.64]:34638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmiZO-0008TB-Ki for 51346@debbugs.gnu.org; Mon, 15 Nov 2021 15:27:15 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id EC3B5184B88; Mon, 15 Nov 2021 20:27:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1637008033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kDU0e5xGxcuQE2tMMKwxkJx2FP1sP1FJDslz13p8sDM=; b=cgrRaqn6QO6vXy6Pv8Vv7/ZXgHqhQuCFI6N4QUN5Hd3hWUeQoxYrifh/OjAG4+L/k4Gsix hGAXlG7hOIbh1z/1dKDhL5dWcX/9bDwKbEnFOA1ikcY+JPqMTY9naxRlcBU9bri68rdzZV wvFe1MUksUgTPwd14eOFJ+tMfuGXrDphF7uQdHoRxSXgpS6ic1RkLf/6FqpuNwVst7Apaa XlmnnRiDJ3Px67WXxxC/oVCUVoyiKz2SjvJswQv74IMFZb0nYnp86pxJ2DOnq5i9B5OjVh UnD4JLLQzmBaYIx71HCAO+RvapgL4I3W//B5eaMBsgvUJtlSuhJ/v7Z1TtVYsw== Date: Mon, 15 Nov 2021 20:26:26 +0000 Message-Id: <20211115202631.6032-1-dev@jpoiret.xyz> In-Reply-To: <87y25p65on.fsf_-_@gnu.org> References: <87y25p65on.fsf_-_@gnu.org> MIME-Version: 1.0 X-Spamd-Bar: ++++ Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: Josselin Poiret X-ACL-Warn: , Josselin Poiret via Guix-patches X-Patchwork-Original-From: Josselin Poiret via Guix-patches via From: Josselin Poiret X-getmail-retrieved-from-mailbox: Patches Hello Tobias and Ludovic, Thanks for the review! Here is hopefully the last patchset, which addresses most of the issues. I decided not to merge the doc changes with the first commit as it also describes swap flags, but that's just a matter of taste I suppose. Moved the deprecation warning that I originally put in gnu/services/base.scm (swap-service) to a sanitizer of swap-devices in its own commit, although it only reports the location of the (operating-system) syntax use, not of the field itself (but that is what I also noticed for other deprecation warnings, alas). I marked the field as delayed, otherwise I was getting a lot of warnings while testing rather than the only one I'm getting now. Fixed the swap-device dependency filtering to silently ignore old-style values rather than erroring out. Overall, I cleaned up all the rogue TABs I had inserted! (setq-default indent-tabs-mode nil) for our Emacs readers at home. This should not happen any more as I have set whitespace-mode to an aggressive red highlighting for TAB characters. And finally, I changed the examples at the end to simply be @lisp blocks, outside of a table. Josselin Poiret (5): gnu: system: Rework swap space support, add dependencies. gnu: system: Warn about swap-devices format change gnu: system: Add swap flags. gnu: system: Filter out boot dependencies from swap-space. doc: Add new Swap Space section. doc/guix.texi | 147 +++++++++++++++++++++++-------- gnu/build/file-systems.scm | 36 +++++++- gnu/services/base.scm | 105 +++++++++++++++------- gnu/system.scm | 40 ++++++++- gnu/system/examples/desktop.tmpl | 7 +- gnu/system/file-systems.scm | 24 ++++- guix/build/syscalls.scm | 12 +++ 7 files changed, 294 insertions(+), 77 deletions(-)