From patchwork Sun Nov 14 12:41:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Philip McGrath X-Patchwork-Id: 447 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id DA5CD27BBE3; Sun, 14 Nov 2021 12:44:01 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 6B85C27BBE1 for ; Sun, 14 Nov 2021 12:44:01 +0000 (GMT) Received: from localhost ([::1]:41224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmErY-0002Ju-E7 for patchwork@mira.cbaines.net; Sun, 14 Nov 2021 07:44:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34868) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmEqc-0002I0-DF for guix-patches@gnu.org; Sun, 14 Nov 2021 07:43:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37821) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmEqc-0007aP-3u for guix-patches@gnu.org; Sun, 14 Nov 2021 07:43:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mmEqb-0004Lr-UA; Sun, 14 Nov 2021 07:43:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH 00/11] guix: node-build-system: Support compiling add-ons with node-gyp. Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: pierre.langlois@gmx.com, guix-patches@gnu.org Resent-Date: Sun, 14 Nov 2021 12:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 51838@debbugs.gnu.org Cc: Philip McGrath , Pierre Langlois X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Pierre Langlois Received: via spool by submit@debbugs.gnu.org id=B.163689373316661 (code B ref -1); Sun, 14 Nov 2021 12:43:01 +0000 Received: (at submit) by debbugs.gnu.org; 14 Nov 2021 12:42:13 +0000 Received: from localhost ([127.0.0.1]:49366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmEpp-0004Ke-Aw for submit@debbugs.gnu.org; Sun, 14 Nov 2021 07:42:13 -0500 Received: from lists.gnu.org ([209.51.188.17]:42278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmEpn-0004KV-HG for submit@debbugs.gnu.org; Sun, 14 Nov 2021 07:42:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmEpn-0001ra-6A for guix-patches@gnu.org; Sun, 14 Nov 2021 07:42:11 -0500 Received: from [2607:f8b0:4864:20::829] (port=35467 helo=mail-qt1-x829.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmEpa-0007Rr-GN for guix-patches@gnu.org; Sun, 14 Nov 2021 07:42:10 -0500 Received: by mail-qt1-x829.google.com with SMTP id j17so13012909qtx.2 for ; Sun, 14 Nov 2021 04:41:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philipmcgrath.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fd2XS7xL/uD+QIR1ubJy0Jx5AhsLDZMHFDqSi0Jsc5Y=; b=eO1kvBrk9RG/kzdprYOu3Xu/fmN3fHZf7LS5kMUKdLpqI5RKjlTplZlzyhwszzcl12 iAxT3XilIk8rcdwgdlLSDzEpUmafr6M2QcDKNVKBLg8fLj3+fzzbPVcReHtYM8co3A3e NoTank7nNC/ANg7B+UYzSmu/+2yR2opiaq9Y3k3jYa4QCpyY56Yq9YiGlV8A6n7kcHE0 uo3Ll2Mr7zKroO6Qnkj5CUocbkiahVCCJAfDTcQBf7c+IdcLnwMqJUALsUQ8ObODfA21 w98dBLmaGVKGsEbSWGOSjfeWOWkATIg52nRYc1dzb1zr4zoFbWWsWDPZxIiIMxLj/89U Vn4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fd2XS7xL/uD+QIR1ubJy0Jx5AhsLDZMHFDqSi0Jsc5Y=; b=2L0ZaMlhbGa+NIvua07y7IZIQ/n6N1O4CbpPO3xBBrPecJzGPV6fIqWFCaMRSZBGQ4 pEZkKOwsAL4IMW88WJsrdiBkbs4HIacN8A7qUUL8JOAyRGI+clluY42+UlHMQSOddOkx kMvTr7NT1acfEwXrPt6B0f8LBSBf4JdNiPd4Nxblnf3iLv+gknpYM8y+xvLK+W8HKOOU rUxIDBT9SAOuIUUfmEffRsQ7fQjR04yJLkTfgOk7c4NThWRAJQFI/naYDIS6eskBG8Ns Vmh8HpWhDRwWJgiWbNlCPZIX1zHu+M8rJ5G5ETaySxAVFxEWk4Fa3EvrUcNm0opkVFZZ RYdw== X-Gm-Message-State: AOAM5334MYy+3m+xJaEW4JGOB/SiU6sLHXSbW5jSuJaYh4wIOaPCAqDs 12K/HaWb6GkqEpITQiNbA66OgLI+g2OK5GYQ X-Google-Smtp-Source: ABdhPJwlFlHIEQ0A4VSmBcMcPqVrqIw++TK2bC9YylM9u6oJTXEcdSVMDDm1xvMFY7Mdgf5vKgJnmw== X-Received: by 2002:a05:622a:20e:: with SMTP id b14mr26456357qtx.288.1636893715329; Sun, 14 Nov 2021 04:41:55 -0800 (PST) Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242]) by smtp.gmail.com with ESMTPSA id y16sm5916760qtm.12.2021.11.14.04.41.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Nov 2021 04:41:55 -0800 (PST) From: Philip McGrath Date: Sun, 14 Nov 2021 07:41:51 -0500 Message-Id: <20211114124151.36743-1-philip@philipmcgrath.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::829 (failed) Received-SPF: neutral client-ip=2607:f8b0:4864:20::829; envelope-from=philip@philipmcgrath.com; helo=mail-qt1-x829.google.com X-Spam_score_int: 0 X-Spam_score: -0.1 X-Spam_bar: / X-Spam_report: (-0.1 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, PDS_HP_HELO_NORDNS=0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches This patch series adds support to `node-build-system` for building native add-ons using `node-gyp`. To confirm that the changes to the build system work, the patch series also adds two packages (plus a few dependencies) representing two major ways of writing Node.js native add-ons: 1. `node-openzwave-shared` uses `node-nan`: “Native Abstractions for Node.js”. 2. `node-sqlite3` uses the Node-API via `node-addon-api`. The patches are adapted from part of a series by Pierre Langlois at : you can find discussion of an earlier version of this spun-off series from to . They are also available in a Git repository at . In the earlier discussion, Pierre and I both thought it was quite confusing that the Scheme variable `node` refers to the bootstrap Node.js, while `node-lts` refers to the newer Node.js that a package specification of `"node"` would resolve to. My analysis is at (tl;dr it seems like an unintentional mistake), and Pierre suggested a solution in . I haven't taken that on in this patch series, but I do think its worth considering. Philip McGrath (11): gnu: node: Avoid duplicating build phases. gnu: node: Update to 10.24.1 for bootstrapping. guix: node-build-system: Support compiling add-ons with node-gyp. gnu: Add node-inherits. gnu: Add node-safe-buffer. gnu: Add node-string-decoder. gnu: Add node-readable-stream. gnu: Add node-nan. gnu: Add node-openzwave-shared. gnu: Add node-addon-api. gnu: Add node-sqlite3. gnu/packages/node-xyz.scm | 335 +++++++++++++++++++++++++++++++ gnu/packages/node.scm | 143 +++++-------- gnu/packages/zwave.scm | 55 +++++ guix/build-system/node.scm | 11 +- guix/build/node-build-system.scm | 23 +++ 5 files changed, 473 insertions(+), 94 deletions(-)