From patchwork Thu Sep 30 22:56:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philip McGrath X-Patchwork-Id: 352 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 4B79527BBE3; Thu, 30 Sep 2021 23:58:12 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 17DE227BBE1 for ; Thu, 30 Sep 2021 23:58:12 +0100 (BST) Received: from localhost ([::1]:36980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mW50F-0008EY-2j for patchwork@mira.cbaines.net; Thu, 30 Sep 2021 18:58:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55262) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mW506-0008EA-6F for guix-patches@gnu.org; Thu, 30 Sep 2021 18:58:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42736) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mW505-0008Hx-Ug for guix-patches@gnu.org; Thu, 30 Sep 2021 18:58:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mW505-0000bQ-Ja for guix-patches@gnu.org; Thu, 30 Sep 2021 18:58:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49946] [PATCH 0/3] guix: node-build-system: Support compiling addons with node-gyp. Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 30 Sep 2021 22:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49946 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 49946@debbugs.gnu.org Cc: Pierre Langlois , Maxime Devos , Philip McGrath Received: via spool by 49946-submit@debbugs.gnu.org id=B49946.16330426712297 (code B ref 49946); Thu, 30 Sep 2021 22:58:01 +0000 Received: (at 49946) by debbugs.gnu.org; 30 Sep 2021 22:57:51 +0000 Received: from localhost ([127.0.0.1]:54282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mW4zv-0000az-4B for submit@debbugs.gnu.org; Thu, 30 Sep 2021 18:57:51 -0400 Received: from mail-qv1-f49.google.com ([209.85.219.49]:37763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mW4zs-0000al-Of for 49946@debbugs.gnu.org; Thu, 30 Sep 2021 18:57:49 -0400 Received: by mail-qv1-f49.google.com with SMTP id o15so4588588qvq.4 for <49946@debbugs.gnu.org>; Thu, 30 Sep 2021 15:57:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philipmcgrath.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PQGTRAqMVGHU0aiOq2VcNYA2rsuCKasKWH5V7qeoyq8=; b=FuyNmJjJagA1edanADCbl4LYW9KrCgAYZmCo9kbVr1TdZGcQ0VOuiiQJYXAXeS+P+q XrfqgtTbxXqS32zVzmwamcrGB/NpKqz/IGc/nCivuCbcm2qnNau1sk8Yw8rms1boULjs LayHep10fMlKDokYNjEVANrKFvoX0H87AZI44u8CGe0uljXjgstg4fTOiGyigJm9oR90 m+h7hUOJEpsxZZQrmY5IjbI6g8AOCg3FIg/IMLBC9Vg9lMzM6++OelExiWJPggICslzn NxyuWNLyuER3dmKCCvjGlvK1tCB5CdxKQWdAE2beLtrR5oWOdtowrYcBV4b2xQWL8TRL biNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PQGTRAqMVGHU0aiOq2VcNYA2rsuCKasKWH5V7qeoyq8=; b=NWrerTiY6Ii/cIH4497Gz0oJu2NG7OdsqXk6EGhWMwDhQlUDOEXb2KNdH/8FHGV95e d9874TWZLfgyR1ImrqDr9OzzdkBXLP59n6MIkmddNX/u7xRS7Fc9I8AvKfHPRA/TQHlM 8hMC9YjkzgL5h8C7nYBHls6tP9JUt8XsoPKjNsKyFhQ4Go26554Ss+0HQVeDh0Opkct9 aIQM3XKe7jog6pZO2ABkaqcmckOTkrsHA9E+axGCCe2crFLK/gfKsVD2WUkhYAhTJcv6 7VKs2xZXj+MQhjzbHbK/vlVMC9dCoQN1EYbc6vQkfc1T81uptH1iSHDyXBmB1oFQXSgW BCVw== X-Gm-Message-State: AOAM530SF9JUJoG2HmZ6iLp4BwnPZ2UJ9ZzVvzDjVcODMWEEfWrzaETw xh26sE/pOF3TZSmU+cW6bjgEKyVB7ZXz9Slf X-Google-Smtp-Source: ABdhPJyJAl7gaQw0swzz3cvrZB4LAZjZQSvgded7AoJw6mkwlxf+Ac9JAmUAYo/DlLvmAktS7b7SFA== X-Received: by 2002:ad4:5664:: with SMTP id bm4mr7781367qvb.53.1633042662908; Thu, 30 Sep 2021 15:57:42 -0700 (PDT) Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242]) by smtp.gmail.com with ESMTPSA id g1sm2088327qkd.89.2021.09.30.15.57.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Sep 2021 15:57:42 -0700 (PDT) From: Philip McGrath Date: Thu, 30 Sep 2021 18:56:08 -0400 Message-Id: <20210930225611.2143194-1-philip@philipmcgrath.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <682f2ed3-90bd-a9f8-1193-34bef399ca62@philipmcgrath.com> References: <682f2ed3-90bd-a9f8-1193-34bef399ca62@philipmcgrath.com> <87h7fztt60.fsf@gmx.com> <20210808233354.6745-1-pierre.langlois@gmx.com> <20210808233354.6745-8-pierre.langlois@gmx.com> <42e10baddb6afe308f67c3240bf5da8159e6f118.camel@telenet.be> <87o88gq5p5.fsf@gmx.com> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi, I've reworked the part of the patch series dealing with node-gyp. I'd like to find an NPM addon package to submit as part of this series, too, basically as a test case. If I can find one that doesn't raise too many other complications, I may send this in as a separate patch, but feel free to try it with tree-sitter, too. There are a few things I'm still not sure about. I haven't made node-build-system add libuv as an implicit input, because I think some node-gyp addons don't actually need libuv, but maybe it's common enough that it should be done automatically. Likewise, I haven't tried to change the issue of `node` referring to `node-bootstrap`, but I still think it should be changed. These patches are also on GitLab at . Improvements welcome! -Philip Philip McGrath (3): gnu: node: Avoid duplicating build phases. gnu: node: Update to 10.24.1 for bootstrapping. guix: node-build-system: Support compiling addons with node-gyp. gnu/packages/node.scm | 187 ++++++++++--------------------- guix/build-system/node.scm | 7 +- guix/build/node-build-system.scm | 9 ++ 3 files changed, 74 insertions(+), 129 deletions(-)