| Message ID | 20210819072156.90545-1-me@bonfacemunyoki.com |
|---|---|
| Headers | show |
| Series | go-github-com-aswinkarthik-csvdiff package updates | expand |
Hi Bonface, Thanks for the patches! Some feedback follows. 1. I think we can combine the two commits into one since this is logically just a single change. 2. We should retain the old package as a deprecated package. We should add something like the snippet below. --8<---------------cut here---------------start------------->8--- (define-public go-github-com-aswinkarthik-csvdiff (deprecated-package "go-github-com-aswinkarthik-csvdiff" csvdiff)) --8<---------------cut here---------------end--------------->8--- > (define-public go-github-com-aswinkarthik-csvdiff 3. We should rename the variable name as well. > (package > - (name "go-github-com-aswinkarthik-csvdiff") > + (name "csvdiff") 3. We should also move the package to some file other than golang.scm. How about textutils.scm? Thank you for your patience! :-) Arun
Hi Bonface, Any progress on this? Just a gentle ping. Thanks, Arun
Arun Isaac <arunisaac@systemreboot.net> anaandika: > Hi Bonface, > > Any progress on this? Just a gentle ping. > > Thanks, > Arun Hi! Lemme have a look at this once my classes are done. Somehow this got lost in my To-Do tasks! Thanks for the reminder.
> Hi! Lemme have a look at this once my classes are done. Somehow this > got lost in my To-Do tasks! Thanks for the reminder. Sure, Bonface, thanks!
Hi all. Find attached the updated package definition of csv diff which addresses the following issues that were kindly pointed out by Sarah: --8<---------------cut here---------------start------------->8--- Typically end-user Go packages will want inputs/native-inputs rather than propagated inputs unless the input provides a binary used at runtime, so user profiles are not cluttered (go-build-system needs source from all transitive dependencies). Also, a more friendly name ("csvdiff" is available) might be better for end-user packages like this. --8<---------------cut here---------------end--------------->8--- BonfaceKilz (2): gnu: go-github-com-aswinkarthik-csvdiff: Rename name to "csvdiff". gnu: go-github-com-aswinkarthik-csvdiff: Make inputs native. gnu/packages/golang.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)