mbox series

[bug#48696,0/3] Documenting commit reverts and revocation

Message ID 20210527123259.4115-1-ludo@gnu.org
Headers show
Series Documenting commit reverts and revocation | expand

Message

Ludovic Courtès May 27, 2021, 12:32 p.m. UTC
Hello Guix!

Attached is an attempt to:

  1. Structure the “Commit Access” section of the manual;

  2. Document how to address committers’ mistakes, when to revert
     commits;

  3. Explain under what circumstances maintainers may revoke commit
     rights.

It essentially codifies unwritten rules, but as always, I think it’s
better to be explicit about the rules and community expectations.

Let me know what you think!  I propose to leave a comment period
of at least one week, possibly iterating with new versions.

Ludo’.

Ludovic Courtès (3):
  doc: Structure the "Commit Access" section.
  doc: Add "Addressing Mistakes" section.
  doc: Explain more reasons for commit revocation.

 doc/contributing.texi | 114 ++++++++++++++++++++++++++++++++++--------
 1 file changed, 93 insertions(+), 21 deletions(-)

Comments

Leo Famulari May 27, 2021, 2:16 p.m. UTC | #1
On Thu, May 27, 2021 at 02:32:59PM +0200, Ludovic Courtès wrote:
> Hello Guix!
> 
> Attached is an attempt to:
> 
>   1. Structure the “Commit Access” section of the manual;
> 
>   2. Document how to address committers’ mistakes, when to revert
>      commits;
> 
>   3. Explain under what circumstances maintainers may revoke commit
>      rights.
> 
> It essentially codifies unwritten rules, but as always, I think it’s
> better to be explicit about the rules and community expectations.
> 
> Let me know what you think!  I propose to leave a comment period
> of at least one week, possibly iterating with new versions.

Thanks for putting this together. It looks good to me!
Tobias Geerinckx-Rice May 30, 2021, 12:49 p.m. UTC | #2
Ludovic Courtès 写道:
> It essentially codifies unwritten rules, but as always, I think 
> it’s
> better to be explicit about the rules and community 
> expectations.

Looks good to me modulo obvious typos like the ‘called’ pointed 
out by Julien.

I *don't* think the text assigns too much potential blame. 
Responsibility, yes.

Thanks Ludo'!

T G-R